Fetch gasPrice and estimate gas in Wrapped Keys LA if not provided
#501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DashKash54
reviewed
Jun 10, 2024
local-tests/tests/testEthereumBroadcastWrappedKeyWithDefaultGasParams.ts
Show resolved
Hide resolved
DashKash54
reviewed
Jun 10, 2024
DashKash54
requested changes
Jun 16, 2024
Comment on lines
+15
to
+16
| * ❌ NETWORK=manzano yarn test:local --filter=testEthereumBroadcastWrappedKeyWithFetchGasParams Fails with Error: Error: There should be exactly 1 element in the capabilities array but there are: 2 | ||
| * ❌ NETWORK=localchain yarn test:local --filter=testEthereumBroadcastWrappedKeyWithFetchGasParams |
There was a problem hiding this comment.
Yeah I'll fix it in the SDK and then there's corr fix in the Lambda as well @MaximusHaximus
@DashKash54 yes, the tests are successful against cayenne, and I've also tested sending txs on Sepolia manually using cayenne as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to the Wrapped Keys Lit Action:
gasPriceif not provided by usergasLimitnot provided by userAlso adds a new test
testEthereumBroadcastWrappedKeyWithDefaultGasParams