Add customElements.getName#458
Merged
ADKaster merged 1 commit intoLadybirdBrowser:masterfrom Jul 6, 2024
Merged
Conversation
Collaborator
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
6f01331 to
15c460f
Compare
tcl3
reviewed
Jul 6, 2024
Userland/Libraries/LibWeb/HTML/CustomElements/CustomElementRegistry.cpp
Outdated
Show resolved
Hide resolved
15c460f to
943c49e
Compare
ADKaster
approved these changes
Jul 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the CustomElementRegistry getName function, as specified.
Verified that it works by visiting wpt.live getName tests and seeing that the test passes.