[E-1] 01-BASIC / 01-Follow the Installation Video_Mac #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git commit -m " [Team] 기존1팀 [Title] 01-BASIC / 01-Follow the Installation Video_Mac [Version] initial [Language] ENG "
jeong-wooseok
requested changes
Jan 4, 2025
There was a problem hiding this comment.
- Review OS: Windows
- Template Rule 가이드를 준수 하였는가: YES
- Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?: YES
- 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?: YES
- import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?: YES
- 모든 코드가 동작에 오류 없이 동작하는가? : Yes
- 기타 의견:
- 깃클론 주소를 https://github.com/LangChain-OpenTutorial/LangChain-OpenTutorial로 변경해주세요 (터미널 캡처가 필요)
- table of contents 기준은 ## 까지이기에 변경했습니다.
- 가이드에 공지된 바와 같이 follow-the-Installation-video_mac-01.png~06.png로 사진파일명 변경해주세요
피드백 반영하였습니다. (Updated TOC, image filenames, and Git clone URL) Co-Authored-By: jeong-wooseok <[email protected]>
jeong-wooseok
previously approved these changes
Jan 4, 2025
|
jeongkpa
requested changes
Jan 4, 2025
There was a problem hiding this comment.
Review OS: Windows
Template Rule 가이드를 준수 하였는가: YES
Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?: YES
이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?: YES
import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?: YES
모든 코드가 동작에 오류 없이 동작하는가? : Yes
기타 의견:
오타만 수정하면 완벽할 것 같습니다!! @ThePurpleCollar
| " ```bash\n", | ||
| " pyenv install 3.11\n", | ||
| "\n", | ||
| "- Set Python 3.1 as the global Python version:\n", |
There was a problem hiding this comment.
여기 오탈자가 있습니다 Python 3.11 로 변경해야합니다!
| " \n", | ||
| "\n", | ||
| "\n", | ||
| "- The repository will be cloned into a folder named langchain-kr within the selected directory.\n" |
There was a problem hiding this comment.
git clone 하면 LangChain-OpenTutorial과 같이 폴더가 생길 거에요! 이 부분 수정해야할것 같습니다.
lanchain-kr -> LangChain-OpenTutorial
수정 사항 - 오탈자 수정 - 폴더 이름 수정 - 한글 -> 영문 수정
jeongkpa
approved these changes
Jan 4, 2025
|
@jeong-wooseok 우석님도 Approve 주시면 좋을 것 같습니다! 2개의 어프로브가 있어야 머지가 가능해서요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git commit -m "
[Team] 기존1팀
[Title] 01-BASIC / 01-Follow the Installation Video_Mac [Version] initial
[Language] ENG
"