-
Notifications
You must be signed in to change notification settings - Fork 282
[E-2] 03-OutputParser / 01-PydanticOutputParser #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Title] PydanticOutputParser [Version] second [Language] ENG [Packgage] langchain-openai, langchain-core, pydantic
BokyungisaGod
previously approved these changes
Jan 6, 2025
[Title] 02-RAG-Advanced.ipynb [Version] initial [Language] ENG [Packgage] "bs4", "faiss-cpu", "pypdf", "unstructured", "unstructured[pdf]", "chromadb", "rank_bm25", "langsmith", "langchain", "langchain_text_splitters", "langchain_community", "langchain_core", "langchain_openai", "langchain_experimental"
[PR Open] 불가 이슈 확인으로 잠시 닫겠습니다. (다시 열도록 하겠습니다.) |
|
수정사항들 모두 수정하였습니다. 기존 PR이 끝나면 재PR하도록 하겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Description of the issue & Suggested Fix or Improvement
참고링크
오탈자 수정
Table of Contents 쪽 - [Environement Setup]~에서 Environement를
Environment로 수정 -> O
!pip install langchain-opentutorial를
%pip install langchain-opentutorial로 수정
*참고: 앞으로도 ! 대신 %로 통일 할 것 같습니다 수정 -> O
-You can checkout the [langchain-opentutorial]~ 에서 checkout 를
check out로 수정 수정 -> O
마크다운 형식
.env를 .env로 수정 수정 -> O
문법 교정
For example, you can return instructions as a string that describe the fields ~ 에서 describe를
describes로 수정 수정 -> O
easy-to-use environment setup, useful에서 setup를
setups로 수정 수정 -> O
'functions' 뒤에 쉼표 추가: useful functions and utilities → useful functions, and utilities (크게 신경쓸만한 포인트는 아닌 것 같지만 한번 수정해봤습니다.) 수정 -> O
'such as' 앞에 쉼표 추가: "API keys such as OPENAI_API_KEY" → "API keys, such as OPENAI_API_KEY" 수정 -> O
'an'삭제: When provided with an email content → When provided with email content 수정 -> O
+) 수정하시고 리뷰어 걸어주실 때, 저랑 규식(Q0211)님 걸어주시면 됩니다!
이미 MR되있는 파일을, 리뷰어님들의 교정을 받아 수정하였습니다.
추가적으로 제목에 오탈자가 있어서 수정하였습니다.
01-PydanticOuputParser -> 01-PydanticOutputParser
고생해주신 보경님, 규식님 감사드립니다.
Author Checklist
[O] PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
[O ] Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.