Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[N-1] 06-DocumentLoader / 06-WordLoader #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2025
Merged

[N-1] 06-DocumentLoader / 06-WordLoader #145

merged 2 commits into from
Jan 7, 2025

Conversation

suhyun0115
Copy link
Contributor

@suhyun0115 suhyun0115 commented Jan 5, 2025 •
edited
Loading

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@teddylee777 teddylee777 added the proofreading 번역/검수팀 제안사항 반영 label Jan 6, 2025
@BAEM1N
Copy link
Contributor

BAEM1N commented Jan 6, 2025 •
edited
Loading

[Intra] 현재 커밋된 파일명이 06-DocumentLoader/06-WordLoader.ipynb.ipynb로 확인됩니다. 06-DocumentLoader/06-WordLoader.ipynb로 수정해 주시면 감사하겠습니다. 이후 다른 리뷰어분들이 리뷰를 남겨주시면 메인 브랜치에 반영하겠습니다

architectyou
architectyou approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@architectyou architectyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • [✅] Review OS:

    • mac

  • [✅] Template Rule 준수 여부:

    • Template Rule 가이드를 준수하였는가? (Check 표기)

  • [✅] Table of Contents 링크 확인:

    • Table of Contents의 링크가 원활하게 동작하는지 확인하였는가? (Check 표기)

  • [✅] 이미지 파일명 검토:

    • 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가? (Check 표기)

  • [✅] 최신 import 방식 사용 여부:

    • import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가? (Check 표기)

  • [✅] 코드 동작 확인:

    • 모든 코드가 오류 없이 동작하는가? (Check 표기)
    • Warning 발생 시 코멘트에 적어주세요.

  • [✅] 제출 파일 확인:

    • 꼭 필요한 파일들만 제출되었는가?
      • 튜토리얼 외 설정 파일이나 다른 분이 작업한 파일이 포함되었는지 Files Changed에서 확인 부탁드립니다. (Check 표기)

  • 기타 의견:
    오류 없이 잘 동작합니다! 고생 많으셨습니다!

@chaeyoonyunakim chaeyoonyunakim added docs tutorial and removed proofreading 번역/검수팀 제안사항 반영 labels Jan 6, 2025
@suhyun0115
Copy link
Contributor Author

혹시 지금도 파일명이 .ipynb.ipynb일까요??

@architectyou
Copy link
Member

@suhyun0115 저는 파일명 오류 없이 잘 보여집니다.

teddylee777
teddylee777 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@teddylee777 teddylee777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS: Mac
  • Template Rule 준수 여부:
  • Table of Contents 링크 확인:
  • 이미지 파일명 검토:
  • 최신 import 방식 사용 여부:
  • 코드 동작 확인:
  • 제출 파일 확인:
  • 기타 의견:
    모든 코드 동작 확인하였고, Table of Contents URL 동작도 확인 완료 하였습니다.
    튜토리얼 작성하시느라 정말 고생 많으셨습니다.

@teddylee777 teddylee777 merged commit 4ceeabb into LangChain-OpenTutorial:main Jan 7, 2025
3 of 4 checks passed
@suhyun0115 suhyun0115 deleted the feature/6-file-pr branch January 12, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddylee777 teddylee777 teddylee777 approved these changes

@architectyou architectyou architectyou approved these changes

@BokyungisaGod BokyungisaGod BokyungisaGod approved these changes

@seofield seofield Awaiting requested review from seofield

Assignees
No one assigned
Labels
docs tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@suhyun0115 @BAEM1N @architectyou @teddylee777 @BokyungisaGod @chaeyoonyunakim