Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ro-jun
Copy link
Contributor

@ro-jun ro-jun commented Jan 6, 2025

  1. Escape 문자 포함
  2. 한글 -> 영문 수정
  3. 영문 번역 반영

꼼꼼히 체크 해주셔서 감사합니다.

Reviewers로 다른 한분을 어떤 분으로 해야할지 모르겠어서 같은 주제로 pr하신 #170 참고하였는데
BokyungisaGod님으로 하면 될까요~?

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Proofread: 08-Embedding /01-OpenAIEmbeddings.ipynb #141 )

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@ro-jun ro-jun self-assigned this Jan 6, 2025
Copy link
Contributor

@choincnp choincnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨어요!! 완벽합니다 :)

@chaeyoonyunakim chaeyoonyunakim added the proofreading 번역/검수팀 제안사항 반영 label Jan 6, 2025
@teddylee777 teddylee777 merged commit 47da5f0 into LangChain-OpenTutorial:main Jan 7, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proofread: 08-Embedding /01-OpenAIEmbeddings.ipynb
5 participants