[E-2] 11-Reranker / 01-CrossEncoderReranker #183

ThePurpleCollar · 2025-01-06T14:52:23Z

[Title] CrossEncoderReranker
[Version] Initial
[Language] ENG
[Packages] langchain-community, langchain-huggingface, faiss

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

[Title] CrossEncoderReranker [Version] Initial [Language] ENG [Packages] langchain-community, langchain-huggingface, faiss

forwardyoung · 2025-01-08T15:56:52Z

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
TextLoader에서 txt 파일을 load 해야 하는데, txt 파일이 커밋되지 않아 FileNotFoundError가 발생합니다.
이 부분 외에는 문제 없습니다!

forwardyoung · 2025-01-09T01:17:52Z

[리마인드] 정호님 pr 리뷰 남겼습니다!

ThePurpleCollar · 2025-01-09T01:20:31Z

@forwardyoung 화영님, 리뷰 감사합니다! 😊
txt파일은 다른 분들과 중복 업로드 우려가 있어서 제외했는데요. 혹시 저도 업로드 해야되는 거면 말씀해 주세요.

forwardyoung · 2025-01-09T08:25:02Z

@ThePurpleCollar 아 네! 아직 main에 txt 파일이 반영되지 않은 상태이다 보니, 제가 재호님 pr만을 리뷰할 때는 해당 파일이 없어서 에러가 발생하기에 업로드해주셔도 될 것 같습니다!

[Title] CrossEncoderReranker [Version] revised [Language] ENG [Packages] langchain-community, langchain-huggingface, faiss txt 파일 추가했습니다.

ThePurpleCollar · 2025-01-09T12:01:07Z

@forwardyoung 화영님, 텍스트 파일 함께 업로드 했습니다. 확인 부탁드릴께요.

hyeyeoon · 2025-01-09T12:16:42Z

🖥️ OS: Mac
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.

*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.

Code Execution: Code runs without errors.

Comments: {Write freely, 한국어 기술 가능}
코드는 문제 없이 잘 실행되고 설명도 상세하게 기술되었습니다.
다만, 이미 가상환경이 설정된 상태에서 !pip 부분 작성 때문에 불필요한 출력이 발생하는 거 같아 이 부분이 수정되면 좋을 거 같습니다!

[Title] CrossEncoderReranker [Version] revised [Language] ENG [Packages] langchain-community, langchain-huggingface, faiss - 패키지 설치 셀 삭제 하였습니다.

ThePurpleCollar · 2025-01-09T12:22:46Z

@hyeyeoon 혜연님, 패키지 설치 코드 삭제했습니다. 확인 부탁드립니다.

hyeyeoon

안녕하세요! 정호님 @ThePurpleCollar
변경사항 확인했습니다.
다만 해당 부분 warning 이 발생하는데 제 환경이 문제인지 모르겠네요..
출력은 문제 없이 됩니다! 참고 부탁드립니다.

FutureWarning: clean_up_tokenization_spaces was not set. It will be set to True by default. This behavior will be depracted in transformers v4.45, and will be then set to False by default. For more details check this issue: huggingface/transformers#31884
warnings.warn(

forwardyoung · 2025-01-09T15:04:05Z

문제 없이 돌아가는 것 확인했습니다. 수고하셨습니다!

ThePurpleCollar · 2025-01-10T01:26:57Z

@hyeyeoon 혜연님, 피드백 감사합니다. 참고로 확인해 주신 warning이 제 환경에서는 출력되지 않습니다. 이 부분은 다른 분들께 문의해 볼까요?

forwardyoung · 2025-01-10T01:46:15Z

@hyeyeoon 혜연님, 피드백 감사합니다. 참고로 확인해 주신 warning이 제 환경에서는 출력되지 않습니다. 이 부분은 다른 분들께 문의해 볼까요?

저는 안 뜨는 줄 알았는데 아니었네요..! 디스코드 q&a에 올려보시는 것 어떨까요?

ThePurpleCollar · 2025-01-10T14:33:56Z

@hyeyeoon @forwardyoung
혜연님 & 화영님,
Warning Message 출력 이슈 관련해서 알아본 결과,

디코 Q&A 게시판에서는 무리없는(?) 결과라는 의견이시고,
https://discord.com/channels/1314137385881047110/1317511768008036422/1327225450673602641
clean_up_tokenization_spaces를 적용하면 결과에 오류가 발생하며, 검색해 본 결과 현재 SentenceTransformer에서 직접 사용하는 매개변수가 아나라고 하네요.

Warning 출력 이슈 어떻게 처리할지 의견 주시면 감사하겠습니다.

ThePurpleCollar · 2025-01-10T23:43:28Z

@hyeyeoon 혜연님,
Warning message 출력 이슈 @XaviereKU 종호님 도움으로 수정하여 commit 했습니다.
확인 부탁드릴께요.

hyeyeoon

@ThePurpleCollar 안녕하세요. 정호님,
문제 없이 코드 작동하는 것 확인했습니다!
이슈 해결하시느라 고생 많으셨습니다. 감사합니다.

[E-2] 11-Reranker / 01-CrossEncoderReranker

e1c4e58

[Title] CrossEncoderReranker [Version] Initial [Language] ENG [Packages] langchain-community, langchain-huggingface, faiss

ThePurpleCollar requested review from forwardyoung and hyeyeoon January 6, 2025 14:55

chaeyoonyunakim added the docs tutorial label Jan 6, 2025

[E-2] 11-Reranker / 01-CrossEncoderReranker

5c26be0

[Title] CrossEncoderReranker [Version] revised [Language] ENG [Packages] langchain-community, langchain-huggingface, faiss txt 파일 추가했습니다.

[E-2] 11-Reranker / 01-CrossEncoderReranker

3fc8eee

[Title] CrossEncoderReranker [Version] revised [Language] ENG [Packages] langchain-community, langchain-huggingface, faiss - 패키지 설치 셀 삭제 하였습니다.

hyeyeoon reviewed Jan 9, 2025

View reviewed changes

forwardyoung approved these changes Jan 9, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

hyeyeoon approved these changes Jan 11, 2025

View reviewed changes

teddylee777 merged commit b0ce86e into LangChain-OpenTutorial:main Jan 11, 2025
3 of 4 checks passed

This was referenced Jan 11, 2025

[E-2] 11-Reranker / 04-FlashRank-Reranker #280

Merged

[E-2] 11-Reranker / 02-Cohere-Reranker #224

Closed

[E-2] 11-Reranker / 01-CrossEncoderReranker #183

[E-2] 11-Reranker / 01-CrossEncoderReranker #183

Uh oh!

Conversation

ThePurpleCollar commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Author Checklist

Review Template (Intial PR)

Uh oh!

forwardyoung commented Jan 8, 2025 • edited by ThePurpleCollar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

forwardyoung commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThePurpleCollar commented Jan 9, 2025

Uh oh!

forwardyoung commented Jan 9, 2025

Uh oh!

ThePurpleCollar commented Jan 9, 2025

Uh oh!

hyeyeoon commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThePurpleCollar commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyeyeoon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

forwardyoung commented Jan 9, 2025

Uh oh!

ThePurpleCollar commented Jan 10, 2025

Uh oh!

forwardyoung commented Jan 10, 2025

Uh oh!

ThePurpleCollar commented Jan 10, 2025

Uh oh!

ThePurpleCollar commented Jan 10, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

hyeyeoon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ThePurpleCollar commented Jan 6, 2025 •

edited

Loading

forwardyoung commented Jan 8, 2025 •

edited by ThePurpleCollar

Loading

forwardyoung commented Jan 9, 2025 •

edited

Loading

hyeyeoon commented Jan 9, 2025 •

edited

Loading

ThePurpleCollar commented Jan 9, 2025 •

edited

Loading

hyeyeoon left a comment •

edited

Loading