Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[E-4] 05-MEMORY / 01-ConversationBufferMemory #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2025
Merged

[E-4] 05-MEMORY / 01-ConversationBufferMemory #20

merged 2 commits into from
Jan 2, 2025

Conversation

sungchul2
Copy link
Contributor

[Title] Added ConversationBufferMemory
[Version] initial

[Language] ENG

[Package] langchain, langchain-openai

  • Introduced a new Jupyter notebook for the ConversationBufferMemory class, detailing its usage for storing and retrieving conversation history.
  • Included sections on environment setup, message extraction, and integration with ConversationChain.

@sungchul2 sungchul2 self-assigned this Dec 30, 2024
YellowGangneng
YellowGangneng previously approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@YellowGangneng YellowGangneng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맥북에서 코드 정상 작동하는 것까지 확인 완료되었습니다. 리뷰에 남긴 것과 같이 when이 중복해서 나타나는 부분만 수정되면 완벽할 것 같습니다 👍

고생하셨습니다!

@teddylee777 teddylee777 changed the title [Team] Existing content development teams 4 Added ConversationBufferMemory Dec 30, 2024
Shinar12
Shinar12 approved these changes Jan 1, 2025
View reviewed changes
Copy link

@Shinar12 Shinar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review]

  1. Review OS : Mac
  2. Template Rule 가이드를 준수 하였는가 : YES
  3. Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가? : YES
  4. 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가? : N/A(이미지 없음)
  5. import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가? : YES
  6. 모든 코드가 동작에 오류 없이 동작하는가? : YES
  7. 기타 의견: 가이드에 맞춰 잘 작업해주신 것 같습니다 👍

@sungchul2 sungchul2 changed the title Added ConversationBufferMemory [E-4] 05-MEMORY / 01-ConversationBufferMemory Jan 2, 2025
@teddylee777 teddylee777 requested a review from BAEM1N January 2, 2025 04:44
@sungchul2 sungchul2 changed the title [E-4] 05-MEMORY / 01-ConversationBufferMemory [E-4] 05-MEMORY / 01-ConversationBufferMemory Jan 2, 2025
BAEM1N
BAEM1N approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@BAEM1N BAEM1N left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review] - ConversationBufferMemory

  1. Review OS(Windows/Mac/Linux): Mac
  2. Template Rule 가이드를 준수 하였는가(YES/NO): YES
  3. Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?(YES/NO): YES
  4. 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?(YES/NO): N/A
  5. import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?(YES/NO): YES
  6. 모든 코드가 동작에 오류 없이 동작하는가? YES
  7. 기타 의견
  • ConversationBufferMemory는 LangChain 버전 0.3.1부터 사용 중단(Deprecated)되었으며, 향후 릴리스에서 제거될 예정으로 보입니다. 링크
  • ConversationBufferMemory에서 LangGraph 기반의 메모리 관리로 전환이 필요해 보입니다.링크
  • 이 부분은 신규 튜토리얼 개발 팀에서 다룰지 논의가 필요해보입니다.

@teddylee777 teddylee777 added the docs tutorial label Jan 2, 2025
@teddylee777
Copy link
Contributor

@BAEM1N 의견 감사합니다.
LangGraph 쪽으로 추후 이관가능성 때문에 label 달아 놓았습니다.
감사합니다.

YellowGangneng
YellowGangneng approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@YellowGangneng YellowGangneng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!!!😄

@teddylee777 teddylee777 merged commit 3774306 into LangChain-OpenTutorial:main Jan 2, 2025
3 checks passed
@sungchul2 sungchul2 deleted the create-ch05-conversation-buffer-memory branch January 3, 2025 01:05
@harheem harheem mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BAEM1N BAEM1N BAEM1N approved these changes

@Shinar12 Shinar12 Shinar12 approved these changes

@YellowGangneng YellowGangneng YellowGangneng approved these changes

Assignees

@sungchul2 sungchul2

Labels
docs tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sungchul2 @teddylee777 @BAEM1N @Shinar12 @YellowGangneng