[E-1] 10-Retriever / 09-TimeWeightVectorStoreRetriever #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
π₯οΈ OS: Win/Mac/Linux
β
Checklist
- [V] Template: Tutorials follows the required template.
- [YES] Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- [V] Image: Image filenames follow guidelines.
- [V] *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- [V] Code Execution: Code runs without errors.
- Comments: Peer Reviewλ§ μΆκ°ν΄μ£Όμλ©΄ λ κ² κ°μ΅λλ€. κ·Έ μΈ ν° λ¬Έμ μ¬νμ λ°κ²¬νμ§ λͺ»νμ΅λλ€.
|
@hong-seongmin peer-reviewλ μΈνλΌνμμ μλμΌλ‘ λ¨κΈ°λκ²μΌλ‘ μκ³ μμ΅λλ€! |
hong-seongmin
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
π₯οΈ OS: Win
β
Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: ν;;; κ·Έλ κ΅°μ
harheem
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
π₯οΈ OS: Mac
β
Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: μΉμ ν νν 리μΌμ΄λ€μ ππ»
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π₯οΈ OS: Mac/Win
β Checklist
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynbΒ #123)
β Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N