Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

LEE1026icarus
Copy link
Contributor

@LEE1026icarus LEE1026icarus commented Jan 7, 2025

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (Fixes Proofread: 08-Embedding/04-UpstageEmbeddingsΒ #149)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

πŸ–₯️ OS: Win/Mac/Linux   
βœ… Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, ν•œκ΅­μ–΄ 기술 κ°€λŠ₯}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

[Title] UpstageEmbeddings
[Version] initial
[Language] ENG
[Packages] dotenv, langchain_upstage, numpy
- Langchain and UpstageEmbeddings Tutorial
- A tutorial on using Langchain's class to access UpstageEmbeddings.
@LEE1026icarus LEE1026icarus requested a review from choincnp January 7, 2025 05:38
@teddylee777 teddylee777 changed the title [N-3] 08-EMBEDDING / 04-UpstageEmbeddings [N-3] 08-Embedding / 04-UpstageEmbeddings Jan 7, 2025
@choincnp choincnp requested a review from BokyungisaGod January 7, 2025 06:55
Copy link
Contributor

@choincnp choincnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eembed라고 μ˜€νƒ€κ°€ λ‚˜μžˆλ„€μš” γ… γ… γ…  λ‹€μ‹œ μˆ˜μ •ν•΄μ„œ 컀밋 λΆ€νƒλ“œλ €μš”~

[Title] UpstageEmbeddings
[Version] initial
[Language] ENG
[Packages] dotenv, langchain_upstage, numpy
- Langchain and UpstageEmbeddings Tutorial
- A tutorial on using Langchain's class to access UpstageEmbeddings.
@LEE1026icarus
Copy link
Contributor Author

μˆ˜μ •ν•΄μ„œ λ‹€μ‹œ μ»€λ°‹ν–ˆμŠ΅λ‹ˆλ‹€!

@choincnp
Copy link
Contributor

choincnp commented Jan 7, 2025

image
아이고, μ œκ°€ 쑰금 μžμ„Ένžˆ μ°μ–΄λ“œλ¦΄ κ±Έ κ·Έλž¬λ„€μš”.

  • Eembed the Query > Embed the query
  • Embeded the Document > Embed the document
    μž…λ‹ˆλ‹€! μˆ˜μ •ν›„ λ‹€μ‹œ λ©˜μ…˜μ£Όμ‹œλ©΄ κ°μ‚¬ν•©λ‹ˆλ‹€ :)

@chaeyoonyunakim
Copy link
Contributor

μ•ˆλ…•ν•˜μ„Έμš” @choincnpλ‹˜ ν•΄λ‹Ή PR conflict resolve도 ν•¨κ»˜ μš”μ²­λ“œλ¦½λ‹ˆλ‹€

@chaeyoonyunakim chaeyoonyunakim added bug Something isn't working e.g., PR conflict proofreading λ²ˆμ—­/κ²€μˆ˜νŒ€ μ œμ•ˆμ‚¬ν•­ 반영 labels Jan 7, 2025
@choincnp
Copy link
Contributor

choincnp commented Jan 8, 2025

@chaeyoonyunakim conflict resolveλ₯Ό μ œκ°€ ν•΄μ•Όν•˜λŠ”κ±΄κ°€μš”? μ•„λ‹ˆλ©΄ conflict resolveλ₯Ό λΆ€νƒλ“œλ¦¬λΌκ³  ν•˜μ‹œλŠ” κ±΄κ°€μš”?

@LEE1026icarus
Copy link
Contributor Author

Eembed the Query > Embed the query
Embeded the Document > Embed the document
μˆ˜μ •ν•˜κ² μŠ΅λ‹ˆλ‹€. μ œκ°€ κΌΌκΌΌν•˜μ§€ λͺ»ν–ˆλ„€μš”.

conflict 원인 μš°μ„  찾아보고 ν•΄κ²°ν•΄λ³΄κ² μŠ΅λ‹ˆλ‹€

[Title] UpstageEmbeddings
[Version] initial
[Language] ENG
[Packages] dotenv, langchain_upstage, numpy
- Langchain and UpstageEmbeddings Tutorial
- A tutorial on using Langchain's class to access UpstageEmbeddings.
@LEE1026icarus
Copy link
Contributor Author

μ•ˆλ…•ν•˜μ„Έμš” @choincnp λ‹˜ μˆ˜μ •μ΄ μž˜λ˜μ—ˆλŠ”μ§€ 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€!

@chaeyoonyunakim
Copy link
Contributor

@chaeyoonyunakim conflict resolveλ₯Ό μ œκ°€ ν•΄μ•Όν•˜λŠ”κ±΄κ°€μš”? μ•„λ‹ˆλ©΄ conflict resolveλ₯Ό λΆ€νƒλ“œλ¦¬λΌκ³  ν•˜μ‹œλŠ” κ±΄κ°€μš”?

ν•œμ€„ μš”μ•½: PR conflict resolveλŠ” κ°€μž₯ μ΅œμš°μ„  확인 μš”μ²­μ‚¬ν•­μž…λ‹ˆλ‹€. λ°œν–‰μžκ°€ μˆ˜μ •ν•©λ‹ˆλ‹€

TL;DR
λ³Έ PR의 conflictλŠ” 1μ£Όμ°¨ 인프라 μž‘μ—…μ—μ„œ λ³€κ²½λœ 폴더λͺ…이 λ°˜μ˜λ˜μ§€ μ•Šμ•„ μƒκ²Όλ˜ λΆ€λΆ„μž…λ‹ˆλ‹€. 08-Embedding/04-UpstageEmbeddings.ipynb둜 λ³€κ²½λœ 이후 merge conflictκ°€ 사라진 것을 보싀 수 μžˆμœΌμ‹€ κ±°μ—μš”. (그외에도 80μ—¬λͺ…이 μž‘μ—…ν•˜λŠ” λ¦¬ν¬μ§€ν† λ¦¬λ‹€λ³΄λ‹ˆ 크고 μž‘μ€ 변경점듀이 upstreamμ—μ„œ μΌμ–΄λ‚˜κ³  있고 upstream fetchκ°€ μ•ˆλœ 경우 ν˜Ήμ€ PR이 ν„°μΉ˜ν•˜λŠ” λ…ΈνŠΈλΆμ΄ 메인에 μžˆλŠ” 변경점과 μΆ©λŒν•  μˆ˜λ„ μžˆμŠ΅λ‹ˆλ‹€)

일반적으둜 PR λ°œν–‰μžκ°€ conflict resolveλ₯Ό ν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€. (특히 μ €ν¬λŠ” PRλ°œν–‰μžκ°€ μ•žμœΌλ‘œλ„ κ³„μ†ν•΄μ„œ κΈ°μ—¬ν•  λΆ„μ΄μ‹œλ‹ˆ ν•œλ²ˆ conflict κ°€ λ‚œ 것을 ν•΄κ²°ν•˜μ§€ μ•ŠμœΌλ©΄ 계속 반볡될 μ‚¬ν•­μ΄λΌμ„œμš”)

μ–΄λ–€ κ²½μš°μ—λΌλ„ μ›μž‘μžκ°€ 파일 변경을 ν•˜λ©΄ (conflict 해결을 ν•˜λŠ” κ³Όμ •μ—μ„œλ“  λ²ˆμ—­/감수 μˆ˜μ •μ œμ•ˆ λ°˜μ˜μ„ ν•˜λ“ ) 리뷰어가 approvalν•œ κΈ°μ‘΄ 사항이 λ‹€μ‹œ ν’€λ¦¬κ²Œ λ©λ‹ˆλ‹€. 그러면 리뷰어 @choincnp @BokyungisaGod λ‹˜ μž…μž₯μ—μ„œ 일을 λ‘λ²ˆ ν•˜κ²Œ λ˜λŠ” 상황이고, μ›μž‘μž @LEE1026icarus λ‹˜λ„ PR mergeκΉŒμ§€ ν•„μˆ˜μΈ approval 2개λ₯Ό μ±„μš°κΈ° μœ„ν•΄μ„œ μΆ”κ°€ νŒ”λ‘œμ—…μ„ ν•΄μ•Ό ν•©λ‹ˆλ‹€.

μ„€λͺ…이 μ’€ 더 λͺ…ν™•ν–ˆλŠ”μ§€ λͺ¨λ₯΄κ² λ„€μš”.
κ°μ‚¬ν•©λ‹ˆλ‹€ ---- 두 λΆ„ λ¦¬λ·°μ–΄λ‹˜λ“€ λ²ˆμ—­/감수 μˆ˜μ • μ œμ•ˆλΆ€λΆ„ 확인 ν›„ approval μš”μ²­λ“œλ €μš”

@chaeyoonyunakim chaeyoonyunakim removed the bug Something isn't working e.g., PR conflict label Jan 8, 2025
@LEE1026icarus LEE1026icarus requested review from pupba and krkrong January 8, 2025 12:18
@LEE1026icarus
Copy link
Contributor Author

전에 ν•΄λ‹Ή 파일 리뷰λ₯Ό λ§‘μ•˜λ˜ λ¦¬λ·°μ–΄λΆ„λ“€μ—κ²Œ 리뷰 μš”μ²­λ“œλ ΈμŠ΅λ‹ˆλ‹€

[Title] 01-RAG-Basic-PDF
[Version] initial
[Language] ENG
[Packages] dotenv, langchain_teddynote, langchain_text_splitters, langchain_community.document_loaders, langchain_community.vectorstores
, langchain_core.output_parsers, langchain_core.runnables, langchain_core.prompts, langchain_openai
- Langchain and RAG Basic Pdf Tutorial
-A tutorial on accessing basic PDF documents for Retrieval Augmented Generation (RAG) using LangChain..
[Version] initial
[Language] ENG
[Packages] dotenv, langchain_teddynote, langchain_text_splitters, langchain_community.document_loaders, langchain_community.vectorstores
, langchain_core.output_parsers, langchain_core.runnables, langchain_core.prompts, langchain_openai
- Langchain and RAG Basic Pdf Tutorial
-A tutorial on accessing basic PDF documents for Retrieval Augmented Generation (RAG) using LangChain..
@chaeyoonyunakim
Copy link
Contributor

μ•ˆλ…•ν•˜μ„Έμš”, ν•΄λ‹Ή PR은 08-Embedding / 04-UpstageEmbeddings λ…ΈνŠΈλΆμ— λŒ€ν•œ λ²ˆμ—­/κ²€μˆ˜ μž‘μ—…μ΄ μ™„λ£Œλ˜μ–΄ conflict resolve 이후 λ¨Έμ§€ν•  것이라 μ˜ˆμƒν–ˆμ—ˆμŠ΅λ‹ˆλ‹€. 그런데 μ‹ κ·œ 파일 12-RAG / 01-RAG-Basic-PDF 파일이 λ”°λΌλΆ™μ–΄μ„œ κ°œλ°œνŒ€ 리뷰가 진행쀑인 κ²ƒμœΌλ‘œ νŒŒμ•…λ˜λ―€λ‘œ λ²ˆμ—­νŒ€ 리뷰어듀은 μ œμ™Έν•˜κ² μŠ΅λ‹ˆλ‹€. peer-review μ ˆμ°¨λŒ€λ‘œ μ§„ν–‰ν•˜μ‹œλ©΄ λ˜κ² μŠ΅λ‹ˆλ‹€. κ°μ‚¬ν•©λ‹ˆλ‹€

@choincnp choincnp removed their request for review January 10, 2025 09:34
Copy link
Contributor

@pupba pupba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ–₯️ OS: Win
βœ… Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • Image: Image filenames follow guidelines.
  • *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€! μ½”λ“œ 이상 μ—†μŠ΅λ‹ˆλ‹€!

@LEE1026icarus LEE1026icarus requested review from choincnp and removed request for choincnp January 11, 2025 08:09
@LEE1026icarus
Copy link
Contributor Author

μ•ˆλ…•ν•˜μ„Έμš”. @krkrong λ‹€μ‹œ ν•œλ²ˆ approve λΆ€νƒλ“œλ¦½λ‹ˆλ‹€!!

@chaeyoonyunakim chaeyoonyunakim added the bug Something isn't working e.g., PR conflict label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e.g., PR conflict new tutorial suggestions proofreading λ²ˆμ—­/κ²€μˆ˜νŒ€ μ œμ•ˆμ‚¬ν•­ 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proofread: 08-Embedding/04-UpstageEmbeddings
4 participants