Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[E-2]11-Reranker/03-JinaReranker #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

[E-2]11-Reranker/03-JinaReranker #213

merged 1 commit into from
Jan 13, 2025

Conversation

hyeyeoon
Copy link
Contributor

@hyeyeoon hyeyeoon commented Jan 7, 2025 •
edited
Loading

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

cjLee-cmd

This comment was marked as resolved.

Sign in to view

@forwardyoung
Copy link
Contributor

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • Image: Image filenames follow guidelines.
  • *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    수고하셨습니다! 현재 ToC 및 코드 작동 모두 문제 없습니다.

forwardyoung
forwardyoung previously approved these changes Jan 8, 2025
View reviewed changes
@hyeyeoon hyeyeoon requested review from Q0211 and removed request for BAEM1N January 9, 2025 06:52
@BAEM1N BAEM1N self-requested a review January 9, 2025 11:03
BAEM1N

This comment was marked as resolved.

Sign in to view

BAEM1N
BAEM1N previously approved these changes Jan 9, 2025
View reviewed changes
@BAEM1N
Copy link
Contributor

BAEM1N commented Jan 9, 2025

@hyeyeoon
99-TEMPLATE / 00-BASE-TEMPLATE-EXAMPLE.ipynb에 보면 langchain_opentutorial을 이용한 환경 변수 설정 이후 load_dotenv를 설정하도록 안내하고 있습니다. 또한 중간 설명 Markdown도 차이가 있는것으로 보입니다. 해당 템플릿을 참고하셔서 수정해주시면 감사하겠습니다.

@Q0211
Copy link

Q0211 commented Jan 9, 2025

1-8에 대한 검수는 approve로 해도 괜찮을 것 같습니다. 다만, 현재 issue에서 제가 approve 판정을 내려버리면 2주차에 수행하시고 있는 프로젝트에 대한 검수를 어떻게 해야할지 판단이 안서 approve를 미루고 있습니다

cjLee-cmd
cjLee-cmd previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@cjLee-cmd cjLee-cmd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • Image: Image filenames follow guidelines.
  • *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    고생하셨어요. 수고하셨습니다~^^

@hyeyeoon hyeyeoon dismissed stale reviews from cjLee-cmd and BAEM1N via a9a1e32 January 11, 2025 08:11
@hyeyeoon
Copy link
Contributor Author

hyeyeoon commented Jan 11, 2025 •
edited
Loading

@cjLee-cmd @forwardyoung @BAEM1N @teddylee777
수정 중 requirements.txt 가 올라가버려서.. 저희 오픈소스에 있는 버전과 동일하게 수정하여서 올렸습니다.
쉬는 날 죄송스럽지만 승인 확인 해주시면 감사하겠습니다!

cjLee-cmd
cjLee-cmd previously approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@cjLee-cmd cjLee-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[이창준] Approve Request Accepted.

@cjLee-cmd
Copy link
Contributor

cjLee-cmd commented Jan 11, 2025 via email

forwardyoung
forwardyoung previously approved these changes Jan 11, 2025
View reviewed changes
hyeyeoon
hyeyeoon commented Jan 11, 2025
View reviewed changes
Copy link
Contributor Author

@hyeyeoon hyeyeoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forwardyoung @cjLee-cmd
안녕하세요. 화영님, 창준님
conflict가 있어서 해결해서 파일 재업로드 하였습니다.
현재 data 폴더에 txt 파일에서 갈등이 발생하였고, 해당 부분은 다른 분이 올려주신 상태라 txt 파일 갈등을 방지하여 포함하지 않은 상태로 올렸습니다.
확인 부탁드립니다. 감사합니다!

@cjLee-cmd cjLee-cmd self-requested a review January 11, 2025 12:53
@forwardyoung
Copy link
Contributor

네 제 pr에서도 txt 파일 문제 있어서 그 부분 도움 요청드린 상태라 혜연님은 문제 없으실 듯 합니다 !

@teddylee777 teddylee777 removed their request for review January 13, 2025 14:22
@teddylee777 teddylee777 merged commit d12509e into LangChain-OpenTutorial:main Jan 13, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BAEM1N BAEM1N BAEM1N approved these changes

@forwardyoung forwardyoung forwardyoung approved these changes

@cjLee-cmd cjLee-cmd Awaiting requested review from cjLee-cmd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hyeyeoon @forwardyoung @BAEM1N @Q0211 @cjLee-cmd @teddylee777