Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sunworl
Copy link
Contributor

@sunworl sunworl commented Jan 7, 2025

OPENAI_API_KEY, LANGCHAIN_API_KEY 입력 필요합니다.
pdf 파일 포함

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@sunworl sunworl self-assigned this Jan 7, 2025
table of contents의 이동 기능이 작동하지 않아 수정
LEE1026icarus
LEE1026icarus previously approved these changes Jan 8, 2025
Copy link
Contributor

@LEE1026icarus LEE1026icarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS:

    • Windows / Mac / Linux (Win)
  • Template Rule 준수 여부:

    • Template Rule 가이드를 준수하였는가? (Check 표기)
  • Table of Contents 링크 확인:

    • Table of Contents의 링크가 원활하게 동작하는지 확인하였는가? (Check 표기)
  • 이미지 파일명 검토:

    • 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가? (Check 표기)
  • 최신 import 방식 사용 여부:

    • import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가? (Check 표기)
  • 코드 동작 확인:

    • 모든 코드가 오류 없이 동작하는가? (Check 표기)
    • Warning 발생 시 코멘트에 적어주세요.
  • 제출 파일 확인:

    • 꼭 필요한 파일들만 제출되었는가?
      • 튜토리얼 외 설정 파일이나 다른 분이 작업한 파일이 포함되었는지 Files Changed에서 확인 부탁드립니다. (Check 표기)
  • 기타 의견:
    고생 많으셨습니다.

Copy link
Contributor

@samdaseuss samdaseuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • Image: Image filenames follow guidelines.
  • *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능} install 시 에러가 나는 것 빼고 모두 실행이 잘 됩니다. 수고하셨습니다 :)

@teddylee777 teddylee777 requested a review from BAEM1N January 9, 2025 13:43
@samdaseuss samdaseuss self-requested a review January 9, 2025 14:36
samdaseuss
samdaseuss previously approved these changes Jan 9, 2025
Copy link
Contributor

@samdaseuss samdaseuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • Image: Image filenames follow guidelines.
  • *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

수고하셨습니다:)

@sunworl sunworl dismissed stale reviews from samdaseuss and LEE1026icarus via 2a4d435 January 9, 2025 15:11
BAEM1N
BAEM1N previously approved these changes Jan 10, 2025
Copy link
Contributor

@BAEM1N BAEM1N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Mac
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • Image: Image filenames follow guidelines.
  • *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    • Langchain docs : Build a Chatbot 링크 URL이 https://python.langchain.com/docs/tutorials/chatbot/으로 수정되면 좋을 거 같습니다.
    • 수고하셨습니다!!

samdaseuss
samdaseuss previously approved these changes Jan 10, 2025
Copy link
Contributor

@samdaseuss samdaseuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 :)

@sunworl sunworl dismissed stale reviews from samdaseuss and BAEM1N via 4cf64f7 January 11, 2025 03:49
LEE1026icarus
LEE1026icarus previously approved these changes Jan 11, 2025
Copy link
Contributor

@LEE1026icarus LEE1026icarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@BAEM1N BAEM1N self-requested a review January 11, 2025 06:49
BAEM1N
BAEM1N previously approved these changes Jan 11, 2025
samdaseuss
samdaseuss previously approved these changes Jan 11, 2025
@BAEM1N BAEM1N dismissed stale reviews from samdaseuss and themself via 0f4c660 January 11, 2025 17:08
LEE1026icarus

This comment was marked as abuse.

@teddylee777 teddylee777 merged commit 953177c into LangChain-OpenTutorial:main Jan 12, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants