[E-1] 10-Retriever / 11-Convex-Combination-Ensemble-Retriever #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Title] Ensemble Retriever with Convex Combination (CC) [Version] initial [Language] ENG [Packages] langchain_community, langchain_openai, langchain_core, faiss-cpu, pdfplumber, rank_bm25
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
Comments: 상단 템플릿이 조금 다른 것 같습니다. - Author: Harheem Kim
- Design:
- Peer Review :
- This is a part of LangChain Open Tutorial
|
@hong-seongmin 코멘트 반영하였습니다 감사합니다 :) |
hong-seongmin
previously approved these changes
Jan 9, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
Comments: 템플릿 수정 확인했습니다
hong-seongmin
previously approved these changes
Jan 9, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
Comments: 템플릿 수정 확인했습니다
choincnp
reviewed
Jan 10, 2025
There was a problem hiding this comment.
🖥️ OS: Mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: @harheem 님 안녕하세요, 너무 좋은 튜토리얼이네요! 다만 고칠사항 있어 말씀드립니다.
- Environment Setup에서
!pip insatall langchain-opentutorial에서%pip install langchain-opentutorial로 바꿔주시면 감사하겠습니다! - Environment Setup에서 성민님이 말씀해주신 부분은 set_env 확인하고 dotenv로 넘어가야 템플릿이 맞다고 하신 것 같습니다. set_env에 #로 주석처리된부분 풀어주시고, 예제 템플릿 한번 참고 부탁드릴게요! 아니면 지금 merge된 다른 파일들 참고해보셔도 좋을 것 같습니다.
- PDFPlumberLoader로 split이 정상적으로 되지 않습니다. 확인 부탁드릴게요.
- Convex Combination(CC)등의 내용은 bold, EmsembleRetriever 등의 내용은 backtick처리 부탁드릴게요!
관련내용 카톡첨부드리겠습니다!
|
@choincnp 꼼꼼한 리뷰 감사드립니다. :) comments 1, 2, 4에 대한 내용을 반영하였습니다. 해당 에러를 찾아보니 파일 객체(BufferedReader)가 전달되었을 때 발생합니다. BufferedReader 에러가 잘못 발생할 가능성도 있기 때문에, file path가 올바른지, 라이브러리 버전이 동일한지 등을 확인해야 해결할 수 있을 것 같습니다. 원인 파악을 위한 추가 정보를 알려주시면 감사하겠습니다. |
hong-seongmin
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
Comments: 수고하셨습니다.
3820e70
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N