-
Notifications
You must be signed in to change notification settings - Fork 282
[N-1] 05-AIMemoryManagementSystem / 09-ConversationMemoryManagementSystem #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[N-1] 05-AIMemoryManagementSystem / 09-ConversationMemoryManagementSystem #245
Conversation
…stem - 초안작성 - LangGraph를 사용한 간단한 예시
…stem - remove table of content descriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너무나도 깔끔한 튜토리얼이네요... 저도 승엽님 코드를 스승삼아(?) 더 나은 튜토리얼을 작성해봐야겠습니다!
Long term memory 부분도 기대하겠습니다!
고생하셨고, 조금 더 파이팅입니다!!
"\n", | ||
"## Table of Contents\n", | ||
"\n", | ||
"TODO: 1안, 2안 결정 + ### 제거\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2안은 좀 더 뭔가 교과서적인 느낌이 든다면, 1안은 A-Z까지 흐름을 타면서 알려주는 느낌이 들 것 같네요
뭔가 1안이 Langchain-opentutorial 컨셉이랑 비슷한 느낌이 드네요!
"\n", | ||
"This guide focuses on managing **Short-term** and **Long-term Memory** for conversational AI, specifically for building personalized chatbots. We will explore two implementation paths:\n", | ||
"\n", | ||
"1. **Using LangGraph**: A structured and feature-rich framework for managing AI memory.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
랭그래프를 사용하고, 사용하지 않고 이 두 가지의 구현체를 구현하시려는 저의가 뭔지 궁금합니당 ㅎㅎ
개인적으로는 한 가지 케이스만 있어도 되지 않나..?라는 생각이 들어서요!
"source": [ | ||
"## Database Configuration\n", | ||
"\n", | ||
"In this section, we will set up an **SQLite database** to store Short-term and Long-term Memory information for our chatbot. SQLite is a lightweight, serverless database that is easy to set up and ideal for prototyping or small-scale applications.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
간단하게나마 DB 선정 이유 있는 거 좋네요ㅎㅎ
받아서 돌려보고나서 느낀 점을 바로 적습니다! 1. Overview
2. Markdown
|
…stem - refactored code for better system integration - added comments - added markdown explanations
…om/syshin0116/LangChain-OpenTutorial into ConversationMemoryManagementSystem
주신 피드백 참고해서 1안을 발전시키기로 했습니다. 리뷰 감사 드립니다.ㅎㅎ |
현재 있는 간략항 사용법에 추가로 Short-term과 Long-term 메모리 각각 관리하여 오는 이점을 보여줄 수 있는 Use case를 만들어볼까 합니다ㅎㅎ 오 In-memory 사용량 추적 제가 생각지 못했던 좋은 의견인것 같아요! 위에꺼를 우선저긍로 하되, 꼭 반영해보고 싶네요 리뷰 감사드립니다. 덕분에 좋은 아이디어들이 생긴것 같아요 |
🖥️ OS: Win
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Template (Intial PR)
🖥️ OS: Win/Mac/Linux
✅ Checklist
- [v] **Template**: Tutorials follows the required template.
- [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/**No**)
- [v] **Image**: Image filenames follow guidelines.
- [v] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- [v] **Code Execution**: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
저번보다 설명도 훨씬 많아지고, 예제도 풍부해져서 이해하는데 많은 도움이 되었습니다!
돌리면서 확인해본 결과 모든 코드 다 잘 작동하고, 오타도 없었습니다. 꼼꼼하게 작성해주셔서 리뷰할게 별로 없네요ㅎㅎ 고생 많으셨습니다!
- Table of Contents 링크가 제 VSCode에서는 작동하지 않네요.. 이것만 한번 체크 부탁드려요!
" - `LangGraph` v0.2 offers separate checkpointer libraries (e.g., `MemorySaver`, `SqliteSaver`, `PostgresSaver`)\n", | ||
" - Easily build or adapt custom solutions for specific databases or workflows\n", | ||
"\n", | ||
"## Table of Contents\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저만 안되는건지 모르겠는데... Table of Contents가 작동하지 않습니다! 문법은 다 맞는것 같은데, 왜 안되는지 모르겠네요ㅠㅠ 제 VSCode가 오류라면 넘어가셔도 좋습니다! 체크겸 한번 남겨요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인해보니 정상 작동합니다!
저도 이번에 처음 알게된 사실인데, 아마 ipynb checkpoint가 남아있으셔서 그런것 같아요ㅎㅎ없애주거나, 다른 경로로 파일 다운로드 받아서 정상작동 확인 가능합니다ㅎㅎ
@dancing-with-coffee @YellowGangneng 수정사항이 있어 재 approve 부탁드립니다! 코드는 동일하고, 아래 markdown cell만 하나 추가했습니다 수정사항(01.18)
You can alternatively set API keys such as `OPENAI_API_KEY` in a `.env` file and load them.
[Note] This is not necessary if you've already set the required API keys in previous steps. ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정사항 모두 확인했습니다! 말씀해주신대로 하니 table of contents도 잘 동작하네요ㅎㅎ 다행입니다!! 2주간 고생 많으셨습니다!
덕분에 많이 배웠어요 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생 많으셨습니다!! 정말 너무 튜토리얼이에요. 앞으로 많은 참고가 될 것 같습니다 :) 감사합니다!
74b8825
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅠㅠㅠ리뷰할 때 좀 더 꼼꼼히 해서 해당 부분도 미리 언급을 드렸으면 좋았을텐데 죄송합니다.ㅠㅠ 고생하셨습니다!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이전에 다 확인했어서 빠르게 Approve합니다!
ea5e1d0
into
LangChain-OpenTutorial:main
초안(01.08)
Table of Contents 1안,2안 내용:
추가(01.12)
추가(01.15)
추가(01.18)
추가(01.19)
상단 Google Colab, Github 뱃지 링크 수정
[Note]
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N