[N-3] 13-LangChain-Expression-Language / 12-RunnableRetry #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
제 pr의 코멘트를 먼저 보고 확인하였는데 RunnableRetry 클래스 소개와 함께 with_retry를 같이 하신 점이 좋은 것 같습니다! 생각지도 못하였는데 덕분에 많이 배웁니다. |
stsr1284
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
🖥️ OS: Win/Mac/Linux
✅ Checklist
- [ ✅ ] Template: Tutorials follows the required template.
- [ Yes ] Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- [ ✅ ] Image: Image filenames follow guidelines.
- [ ✅ ] *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- [ ✅ ] Code Execution: Code runs without errors.
- Comments: 고생하셨습니다~
seofield
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
🖥️ OS: Win/Mac/Linux
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
LGTM!
There was a problem hiding this comment.
[Review Checklist]
-
Review OS: Windows
-
Template Rule 준수 여부: 이상없음
-
Table of Contents 링크 확인: 이상없음
-
이미지 파일명 검토: 이미지 파일 없으므로, 해당없음
-
최신 import 방식 사용 여부: 이상없음
-
코드 동작 확인: warning없이 잘 작동함
-
제출 파일 확인: 이상없음
-
기타 의견:
리뷰어팀 전창원입니다.
간결하게 이해가 쉽게 작성되어, 자연스럽게 실행하였습니다.
하단 부분의 cell에서 가로로 약간 길게 된 줄만
가독성을 위해 줄나눔을 하면 어떨까하는 의견을 드려봅니다.
특이한 점은, 제가 실행할 때는 random함수값이 바로 1이 나와서
한번에 success가 나오는 상황이더군요.ㅎㅎㅎ
고생 많으셨습니다. 감사합니다.
changwonjeon
approved these changes
Jan 10, 2025
d26ecdd
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
신규 3팀 RunnableRetry Draft Code입니다.
다음과 같은 사항 피드백 해주시면 감사하겠습니다.
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N