[E-4] 13-LangChain-Expression-Language / 08-RunnableWithMessageHistory #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geminii01
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
[Review Checklist]
-
Review OS:
- Windows / Mac / Linux (Windows)
-
Template Rule 준수 여부:
- Template Rule 가이드를 준수하였는가? (Check 표기)
-
Table of Contents 링크 확인:
- Table of Contents의 링크가 원활하게 동작하는지 확인하였는가? (Check 표기)
-
[ N/A ] 이미지 파일명 검토:
- 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가? (Check 표기)
-
최신 import 방식 사용 여부:
- import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가? (Check 표기)
-
코드 동작 확인:
- 모든 코드가 오류 없이 동작하는가? (Check 표기)
-
제출 파일 확인:
- 꼭 필요한 파일들만 제출되었는가?
-
기타 의견:
- Docker Redis 환경 구성 후 Jupyter Notebook 실행 결과, 정상적으로 동작합니다! 고생하셨습니다.
|
🖥️ OS: Win
|
BaBetterB
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
[O] Template: Tutorials follows the required template.
[O] Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
[] Image: Image filenames follow guidelines.
[O] *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
[O] Code Execution: Code runs without errors.
Comments: 고생하셨습니다. docker 를 통해 세션id 사용하는 기능까지 정상 작동확인하였습니다.
8e74db3
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N