-
Notifications
You must be signed in to change notification settings - Fork 282
[E-1] 10-Retriever / 02-ContextualCompressionRetriever #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- add workflow image - final version
[Review]
|
1. Highlighted specific word with backtick 2. Modify link url 3. add faiss-cpu to package.install
@yuneun92 솔루션까지 친절하게 작성해주시어 더 감사드립니다.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:desktop: OS: Win/Mac/Linux Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No) YES
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
- 코드 동작 잘 합니다 :) 고생하셨습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Review]
Review OS: Mac
Template Rule 가이드를 준수 하였는가: YES
Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?: YES
이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?: YES
import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?: YES
모든 코드가 동작에 오류 없이 동작하는가? : YES
기타 의견: 고생하셨습니다~
911671c
into
LangChain-OpenTutorial:main
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N