Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jhboyo
Copy link
Contributor

@jhboyo jhboyo commented Jan 8, 2025

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@jhboyo jhboyo requested review from r14minji and yuneun92 January 8, 2025 14:22
@jhboyo
Copy link
Contributor Author

jhboyo commented Jan 8, 2025

@r14minji @yuneun92 리뷰 부탁 드리겠습니다.

@yuneun92
Copy link
Contributor

yuneun92 commented Jan 8, 2025

[Review]

  1. Review OS: Mac

  2. Template Rule 가이드를 준수 하였는가: NO

    1. Overview에서 아래 파트의 'ContextualCompressionRetriever'를 백틱으로 감싸주시기 바랍니다.
      image
  3. Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?: NO

    1. 마지막 목차로 이동이 안 됩니다! 아래와 같이 수정하니 이동이 되네요.
      - [Creating a Pipeline (Compressor + Document Converter)](#creating-a-pipeline-compressor--document-converter)
  4. 이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?: YES

  5. import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?: YES

  6. 모든 코드가 동작에 오류 없이 동작하는가? : YES

  7. 기타 의견:

  • (필수 install) pip install에 faiss-cpu 혹은 faiss-gpu 추가 부탁드립니다.

1. Highlighted specific word with backtick
2. Modify link url
3. add faiss-cpu to package.install
@jhboyo
Copy link
Contributor Author

jhboyo commented Jan 8, 2025

@yuneun92 솔루션까지 친절하게 작성해주시어 더 감사드립니다.
안내 주신 부분들 수정하여 push하였습니다.

  1. Highlighted specific word with backtick
  2. Modify link url
  3. add faiss-cpu to package.install

Copy link
Contributor

@r14minji r14minji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:desktop: OS: Win/Mac/Linux Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No) YES
  • Image: Image filenames follow guidelines.
  • *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
  • 코드 동작 잘 합니다 :) 고생하셨습니다!

Copy link
Contributor

@yuneun92 yuneun92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review]

Review OS: Mac

Template Rule 가이드를 준수 하였는가: YES

Table of Contents 의 링크가 원활하게 동작하는지 확인하였는가?: YES

이미지가 포함되어 있다면, 이미지의 파일명이 가이드를 준수하였는가?: YES

import 구문이 예전 legacy 방식이 아닌 최신 버전을 따르는가?: YES

모든 코드가 동작에 오류 없이 동작하는가? : YES

기타 의견: 고생하셨습니다~

@teddylee777 teddylee777 merged commit 911671c into LangChain-OpenTutorial:main Jan 11, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants