-
Notifications
You must be signed in to change notification settings - Fork 282
[N-1] 06-Multimodal/ 10-GeminiMultimodalRAG #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[N-1] 06-Multimodal/ 10-GeminiMultimodalRAG #268
Conversation
Review Template (Intial PR)🖥️ OS: Win/Mac/Linux
✅ Checklist
- [ ] **Template**: Tutorials follows the required template.
- [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
- [ ] **Image**: Image filenames follow guidelines.
- [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- [ ] **Code Execution**: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🖥️ OS: Mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
-
Image: Image filenames follow guidelines. - *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments:
아직 draft이니 포맷관련 내용과 기술적인 부분 구분해서 리뷰드립니다
포맷
- 주석 : 한글 -> 영어로 변경필요합니다.
- 추가 설치 라이브러리 : pip -> langchain_opentutorial 리스트로 추가
set_env
리스트에UPSTAGE_API_KEY
추가- TOC 링크 확인 필요합니다.
- 문서 제목으로 gemini가 들어가있는데 주도적인 역할을 하는지 다시 한번 검토 부탁드립니다.
기술
- 도식화 이미지가 제공되면 전체적인 답변생성 구조를 이해하는데 도움이 될것 같습니다. 참고 링크
- 마지막부분의 예시 질문의 답변 예시를 바꾸거나 로직을 확인해주시면 감사드립니다. 제가 문서를 제대로 이해하지 못해서 그럴수도 있긴한데,

살펴보시고 적용 필요하다고 생각하시는 부분에 대해 반영해주시면 감사드립니다.
정확히 설명하느라 내용이 길어진 것이고 다음주에는 좋은 코드예시가 될 것 같습니다.
고생하셨습니다. 감사합니다 ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
가이드라인에 맞춰 이미지 파일명 수정하였습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🖥️ OS: Win/Mac/Linux
✅ Checklist
- [ x ] Template: Tutorials follows the required template.
- [ x ] Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
- [ x ] Image: Image filenames follow guidelines.
- [ x ] *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- [ x ] Code Execution: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
Code execution has not been checked as a whole, due to quota limit.
However, it would be great if we use `` to call for function, API, or packages, etc; such as pymupdf4llm aspymupdf4llm
.
@HarryKane11 good work. You inspire me with how to handle modality data other than text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve, because those formatting changes may look trivial to content creator.
dc1090b
into
LangChain-OpenTutorial:main
[N-1] 06-Multimodal/ 10-GeminiMultimodalRAG
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.