[E-2] 11-Reranker / 04-FlashRank-Reranker #280

forwardyoung · 2025-01-08T15:31:00Z

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

…Tutorial

ThePurpleCollar

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
가이드에 맞게 모든 내용이 명확하고 잘 정리되어 있네요. 👏
다만, 한 가지 작은 부분만 확인해 주시면 더 좋을 것 같습니다:
Environment Setup 섹션에 포함된 링크가 wikidocs로 연결되고 있는데 한글 문서라서 문제가 없을지 모르겠네요. 필요하다면 이번에 새로 작성한 영문 페이지들로 변경하는 것도 고려해 보면 좋을 것 같습니다.
https://github.com/LangChain-OpenTutorial/LangChain-OpenTutorial/blob/main/01-Basic/01-Getting-Started-Windows.ipynb
https://github.com/LangChain-OpenTutorial/LangChain-OpenTutorial/blob/main/01-Basic/02-Getting-Started-Mac.ipynb

Environment Setup

Set up the environment. You may refer to Environment Setup for more details.

forwardyoung · 2025-01-09T01:14:37Z

🖥️ OS: Win ✅ Checklist

Template: Tutorials follows the required template.

Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)

Image: Image filenames follow guidelines.

*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.

Code Execution: Code runs without errors.

Comments: {Write freely, 한국어 기술 가능}
가이드에 맞게 모든 내용이 명확하고 잘 정리되어 있네요. 👏
다만, 한 가지 작은 부분만 확인해 주시면 더 좋을 것 같습니다:

Environment Setup 섹션에 포함된 링크가 wikidocs로 연결되고 있는데 한글 페ㅣ지라서 문제가 없을지 모르겠네요.

Environment Setup

Set up the environment. You may refer to Environment Setup for more details.

@ThePurpleCollar 리뷰 감사합니다! 한 가지 작은 부분이 wikidocs 말씀하시는 걸까요?

ThePurpleCollar · 2025-01-09T01:15:40Z

@forwardyoung 네. 맞습니다. 한글 문서라서요. 영어 문서 링크 올려두었습니다.

forwardyoung · 2025-01-09T01:16:27Z

@forwardyoung 네. 맞습니다. 한글 문서라서요. 영어 문서 링크 올려두었습니다.

오 네! 감사합니다:)

forwardyoung · 2025-01-09T06:41:54Z

@ThePurpleCollar 테디님께 따로 여쭈었는데, 짚어주신 부분은 인프라팀에서 일괄 작업해주신다고 합니다! 리뷰 감사합니다:)

Restrict python-magic-bin installation to non-macOS platforms in requirements.txt

BAEM1N

🖥️ OS:Mac/Linux
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
Environment Setup 코드 셀의 순서를 아래와 같이 수정 요청드립니다.
1. langchain-opentutorial 패키지 설치 코드 셀
2. from langchain_opentutorial import package 코드 셀
3. from dotenv import load_dotenv 코드 셀
4. # Set local environment variables 코드 셀

Revert commit due to incorrect branch application

forwardyoung · 2025-01-10T07:50:54Z

@BAEM1N 제가 패키지 설치하기도 전에 import 하도록 했었네요..! 순서 변경하여 다시 push 했습니다!

cjLee-cmd

🖥️ OS: Win/Mac/Linux
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
잘 작성된 것으로 보입니다. 고생 하셨어요 !!

forwardyoung · 2025-01-11T12:21:40Z

@teddylee777 @musangk @BAEM1N 안녕하세요. 저 resolve conflicts에서 main 브랜치에 있는 코드로 바로 수정해도 될까요?

BAEM1N · 2025-01-11T12:29:26Z

appendix-keywords.txt에서 수정 방향 말씀해주시면 제가 수정 반영 하겠습니다.

forwardyoung · 2025-01-11T12:39:29Z

@BAEM1N 다음 수정 내용으로 반영해주심 감사하겠습니다. requirements 파일은 직접 수정하신 것이죠??
appendix-keywords.txt

musangk · 2025-01-11T12:48:26Z

@forwardyoung, @BAEM1N
appendix-keywords.txt 파일이 두개 내용은 완전히 같은데, 줄바꿈 형식이 달라서 문제가 발생한 것 같습니다. (OS 차이)

$ file appendix-keywords*.txt
appendix-keywords-forwardyoung.txt: ASCII text
appendix-keywords-main.txt:         ASCII text, with CRLF line terminators

사전에 해당 파일을 포함하는 PR이 windows에서 작성된 것 같습니다.

내용이 완전히 동일하니, 위의 내용을 참고하여 conflict resolve로 처리하면 될 것 같습니다. (둘 중 하나 내용 제거)

BAEM1N · 2025-01-11T12:51:23Z

@forwardyoung @musangk revert 해당 커밋은 메인 브랜치에 바로 적용해도 문제가 없다고 판단되어 메인 브랜치에 바로 적용하였습니다.

@ThePurpleCollar @cjLee-cmd 커밋으로 인한 리뷰 재승인만 부탁드립니다.

forwardyoung · 2025-01-11T13:17:31Z

@cjLee-cmd 창준님 요 pr도 approve 부탁드리겠습니다:)

cjLee-cmd

[승인요청] Appoved

forwardyoung added 5 commits January 8, 2025 23:58

[E-2]11-Reranker/04-FlashRank-Reranker

cf7775b

Merge branch 'main' of https://github.com/forwardyoung/LangChain-Open…

5f63713

…Tutorial

[E-2]11-Reranker/04-FlashRank-Reranker

45fe3d2

[E-2]11-Reranker/04-FlashRank-Reranker

ebdd2ae

[E-2]11-Reranker/04-FlashRank-Reranker

1b8d6bf

forwardyoung changed the title ~~[E-2]11-Reranker/04-FlashRank-Reranker~~ [E-2] 11-Reranker / 04-FlashRank-Reranker Jan 8, 2025

forwardyoung requested review from ThePurpleCollar and cjLee-cmd January 8, 2025 15:33

teddylee777 requested a review from BAEM1N January 8, 2025 15:34

ThePurpleCollar requested changes Jan 9, 2025

View reviewed changes

ThePurpleCollar previously approved these changes Jan 9, 2025

View reviewed changes

ThePurpleCollar self-requested a review January 9, 2025 01:14

cjLee-cmd previously approved these changes Jan 9, 2025

View reviewed changes

BAEM1N requested a review from cjLee-cmd January 9, 2025 10:26

[I] requirements.txt / update requirements.txt

761f505

Restrict python-magic-bin installation to non-macOS platforms in requirements.txt

BAEM1N dismissed stale reviews from cjLee-cmd and ThePurpleCollar via 761f505 January 9, 2025 10:39

BAEM1N requested changes Jan 9, 2025

View reviewed changes

BAEM1N added 3 commits January 9, 2025 19:52

[I] requirements.txt / revert requirements.txt

6a5ffe1

Revert commit due to incorrect branch application

[I] requirements.txt / revert requirements.txt

1646a75

[I] requirements.txt / revert requirements.txt

b460402

cjLee-cmd approved these changes Jan 9, 2025

View reviewed changes

ThePurpleCollar previously approved these changes Jan 9, 2025

View reviewed changes

BAEM1N previously approved these changes Jan 10, 2025

View reviewed changes

cjLee-cmd previously approved these changes Jan 10, 2025

View reviewed changes

Merge branch 'main' into main

5259dd0

BAEM1N dismissed stale reviews from cjLee-cmd, ThePurpleCollar, and themself via 5259dd0 January 11, 2025 12:49

BAEM1N requested review from BAEM1N, ThePurpleCollar and cjLee-cmd January 11, 2025 12:51

BAEM1N approved these changes Jan 11, 2025

View reviewed changes

ThePurpleCollar approved these changes Jan 11, 2025

View reviewed changes

musangk approved these changes Jan 11, 2025

View reviewed changes

cjLee-cmd approved these changes Jan 11, 2025

View reviewed changes

teddylee777 merged commit 9b2cd47 into LangChain-OpenTutorial:main Jan 12, 2025
1 of 2 checks passed

musangk mentioned this pull request Jan 12, 2025

[E-2] 11-Reranker / 02-Cohere-Reranker #224

Closed

3 tasks

sohyunwriter added the docs tutorial label Jan 18, 2025

[E-2] 11-Reranker / 04-FlashRank-Reranker #280

[E-2] 11-Reranker / 04-FlashRank-Reranker #280

Uh oh!

Conversation

forwardyoung commented Jan 8, 2025

Author Checklist

Review Template (Intial PR)

Uh oh!

ThePurpleCollar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Environment Setup

Uh oh!

forwardyoung commented Jan 9, 2025

Environment Setup

Uh oh!

ThePurpleCollar commented Jan 9, 2025

Uh oh!

forwardyoung commented Jan 9, 2025

Uh oh!

forwardyoung commented Jan 9, 2025

Uh oh!

BAEM1N left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

forwardyoung commented Jan 10, 2025

Uh oh!

cjLee-cmd left a comment

Choose a reason for hiding this comment

Uh oh!

forwardyoung commented Jan 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BAEM1N commented Jan 11, 2025

Uh oh!

forwardyoung commented Jan 11, 2025

Uh oh!

musangk commented Jan 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BAEM1N commented Jan 11, 2025

Uh oh!

forwardyoung commented Jan 11, 2025

Uh oh!

cjLee-cmd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ThePurpleCollar left a comment •

edited

Loading

BAEM1N left a comment •

edited

Loading

forwardyoung commented Jan 11, 2025 •

edited

Loading

musangk commented Jan 11, 2025 •

edited

Loading