[E-3] 12-RAG / 01-RAG-Basic-PDF.ipynb #284

LEE1026icarus · 2025-01-09T03:21:57Z

Author Checklist

PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

[Title] UpstageEmbeddings [Version] initial [Language] ENG [Packages] dotenv, langchain_upstage, numpy - Langchain and UpstageEmbeddings Tutorial - A tutorial on using Langchain's class to access UpstageEmbeddings.

…nTutorial

[Version] initial [Language] ENG [Packages] dotenv, langchain_teddynote, langchain_text_splitters, langchain_community.document_loaders, langchain_community.vectorstores , langchain_core.output_parsers, langchain_core.runnables, langchain_core.prompts, langchain_openai - Langchain and RAG Basic Pdf Tutorial -A tutorial on accessing basic PDF documents for Retrieval Augmented Generation (RAG) using LangChain..

sunworl

수고하셨습니다.
몇 가지 수정의견 드렸습니다.
comment 순서가 좀 섞여 있어서, 라인넘버 순서대로 봐주세요

12-RAG/01-RAG-Basic-PDF.ipynb

sunworl · 2025-01-09T13:42:58Z

12-RAG/01-RAG-Basic-PDF.ipynb

+    "\n",
+    "### References\n",
+    "\n",
+    "- [Langchain docs](https://python.langchain.com/docs/how_to/#qa-with-rag)\n",


[langChain docs : QA with RAG] 로 자세히 넣어주시면 더 좋을거 같아요 (다른분들과 통일)

sunworl · 2025-01-09T13:55:10Z

12-RAG/01-RAG-Basic-PDF.ipynb

+    "from langchain_opentutorial import package\n",
+    "\n",
+    "package.install(\n",
+    "    [\"langchain_community\"],\n",


langsmith
langchain
langchain_text_splitters
langchain_core
langchain_openai

추가해주세요

sunworl · 2025-01-09T14:03:50Z

12-RAG/01-RAG-Basic-PDF.ipynb

+    "        \"LANGCHAIN_API_KEY\": \"\",\n",
+    "        \"LANGCHAIN_TRACING_V2\": \"true\",\n",
+    "        \"LANGCHAIN_ENDPOINT\": \"https://api.smith.langchain.com\",\n",
+    "        \"LANGCHAIN_PROJECT\": \"CH08-Embeddings-UpstageEmebeddings\",\n",


"OPENAI_API_KEY" 가 추가되어야 할거 같습니다.

"LANGCHAIN_PROJECT"는 RAG-Basic-PDF 로 수정해주셔야 합니다.

sunworl · 2025-01-09T14:06:31Z

12-RAG/01-RAG-Basic-PDF.ipynb

+    }
+   ],
+   "source": [
+    "# Set up LangSmith tracking. https://smith.langchain.com\n",


langchain_teddynote 는 삭제.
LangSmith 추적 설정 내용을 전체적으로 삭제하셔야 합니다.

12-RAG/01-RAG-Basic-PDF.ipynb

sunworl · 2025-01-09T14:19:43Z

12-RAG/01-RAG-Basic-PDF.ipynb

+     "name": "stdout",
+     "output_type": "stream",
+     "text": [
+      "그에 대한 정보는 제공된 문서에서 찾을 수 없습니다.\n"


저는 답변이 아래와 같이 나옵니다. 제시하신 결과와 다르네요. 확인이 필요할듯 합니다.

"AI의 의료 분야 적용은 지금까지 주로 행정 업무(예: 임상 노트에서 정보를 추출하기 위한 자연어 처리 또는 방문 예측 일정 관리)와 진단(방사선학, 병리학 및 피부과에서의 영상에 적용되는 기계 학습 및 심층 학습)에 국한되어 있습니다."

그리고, 위에서 "Answer in Korean"이 삭제되면 아래와 같이 답변이 나옵니다.

The application of AI in healthcare has been confined to administrative tasks, such as Natural Language Processing to extract information from clinical notes or predictive scheduling of visits, and diagnostic tasks, including machine and deep learning applied to imaging in radiology, pathology, and dermatology.

sunworl · 2025-01-09T14:20:15Z

12-RAG/01-RAG-Basic-PDF.ipynb

+     "name": "stdout",
+     "output_type": "stream",
+     "text": [
+      "AI의 의료 분야 적용은 지금까지 주로 행정 업무(예: 임상 노트에서 정보 추출을 위한 자연어 처리 또는 방문 일정 예측)와 진단(방사선학, 병리학 및 피부과에서의 이미지에 적용되는 기계 학습 및 심층 학습)에 국한되어 있습니다.\n"


위에서 "Answer in Korean" 삭제되면 아래와 같이 답변됩니다.

The application of AI in healthcare has been confined to administrative tasks, such as Natural Language Processing to extract information from clinical notes or predictive scheduling of visits, and diagnostic tasks, including machine and deep learning applied to imaging in radiology, pathology, and dermatology.

sunworl · 2025-01-09T14:30:08Z

12-RAG/01-RAG-Basic-PDF.ipynb

+    "    \"\"\"You are an assistant for question-answering tasks. \n",
+    "Use the following pieces of retrieved context to answer the question. \n",
+    "If you don't know the answer, just say that you don't know. \n",
+    "Answer in Korean.\n",


"Answer in Korean"은 삭제해주세요.
답변은 영어로 나오도록

sunworl · 2025-01-09T14:32:21Z

12-RAG/01-RAG-Basic-PDF.ipynb

+    "    \"\"\"You are an assistant for question-answering tasks. \n",
+    "Use the following pieces of retrieved context to answer the question. \n",
+    "If you don't know the answer, just say that you don't know. \n",
+    "Answer in Korean.\n",


여기도 "Answer in Korean" 삭제

samdaseuss

🖥️ OS: Win/Mac/Linux
✅ Checklist

[] Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments:
Answer in Korean 삭제가 필요해 보입니다.
수정 부탁드립니다.

수고하셨습니다.:)

sunworl

🖥️ OS: Win
✅ Checklist

[O] Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
[O] Image: Image filenames follow guidelines.
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}

수고하셨습니다.
몇 가지 수정의견 드렸습니다.
comment 순서가 좀 섞여 있어서, 라인넘버 순서대로 봐주세요

LEE1026icarus · 2025-01-09T14:54:27Z

어쩐지 한국어로 답변이 나와서 당황했는데.,. 이런 이슈가.. 두 리뷰어분들의 리뷰 감사합니다. 잘 수정하도록 하겠습니다!

LEE1026icarus · 2025-01-10T03:11:35Z

안녕하세요.
리뷰어분들의 피드백을 반영하여 수정하였습니다.

@sunworl @samdaseuss 리뷰 다시 한번 부탁드립니다!!

LEE1026icarus · 2025-01-10T08:25:58Z

12-RAG/assets/12-rag-rag-basic-pdf-rag-process-02.png 이미지가 수정되어 추가적으로 커밋하였습니다.

changwonjeon

[Review Checklist]

Review OS: Windows
Template Rule 준수 여부: 이상 없음
Table of Contents 링크 확인: 1개 연결 확인 필요
- RAG Basic Pipeline (Steps 1–8) -> ()를 빼면 잘 이동합니다. 확인 부탁드립니다.
이미지 파일명 검토: 2개 파일 숫자 변경 필요
- 12-rag-rag-basic-pdf-rag-graphic-1.png => 뒤에 숫자 01으로 변경필요
- 12-rag-rag-basic-pdf-rag-graphic-2.png => 뒤에 숫자 02으로 변경필요
- 다른 2개는 01, 02이라 같은 방식 표기면 좋을 듯 합니다.
최신 import 방식 사용 여부: 이상 없음
코드 동작 확인: 이상 없음
제출 파일 확인: 이상 없음
- (수정) Discord 가이드에 올라온 첨부파일 가이드에 맞춰 작성되었습니다.
기타 의견:
리뷰어팀 전창원입니다.
깔끔하게 코드 작성하셔서, 정상적으로 실행되었습니다.
warning도 별도로 확인되지는 않았습니다.
실행에는 지장 없지만, 통일성을 위해 몇가지 수정을 부탁드립니다.
고생 많으셨습니다. 감사합니다.

12-RAG/01-RAG-Basic-PDF.ipynb

12-RAG/assets/12-rag-rag-basic-pdf-rag-graphic-1.png

12-RAG/assets/12-rag-rag-basic-pdf-rag-graphic-2.png

sunworl · 2025-01-10T16:12:36Z

안녕하세요. 리뷰어분들의 피드백을 반영하여 수정하였습니다.

@sunworl @samdaseuss 리뷰 다시 한번 부탁드립니다!!

파일이 아직 수정이 되지 않은거 같습니다.
여전히 한글이 나오고 있는데요? 파일 확인 부탁드립니다.

samdaseuss

안녕하세요, 오윤지 입니다.

수정사항을 작성했습니다. 확인 부탁드립니다. 감사합니다 :)

12-RAG/01-RAG-Basic-PDF.ipynb

Environment-setup 텍스트 수정

"LANGCHAIN_PROJECT": "RAG-Basic-PDF" 수정했습니다.

sunworl · 2025-01-11T06:15:02Z

2가지 내용을 직접 수정하고 커밋했습니다.
컨텐츠 이동 오류만 수정하시면 될듯합니다.

remove the () Co-authored-by: Jeon Changwon <[email protected]>

LEE1026icarus

콘텐츠 이동 오류 해결되었을까요?
이렇게 수정해도 되는지를 몰라서..

…-rag-graphic-02.png Rename Image 2

…-rag-graphic-01.png Rename Image 1

TOC 수정

"# Create a prompt.\n", removed Co-authored-by: Jeon Changwon <[email protected]>

"# Step 7: Create Language Model (LLM)\n" remove. Co-authored-by: Jeon Changwon <[email protected]>

sunworl

Environment setup 에 오타가 있어서, 직접 수정 후 제대로 작동하는 거 확인했습니다.
수고하셨습니다.

오타가 있어서 수정했습니다.

sunworl

Environement Setup 에 오타가 있어 직접 수정하고 제대로 작동하는 거 확인했습니다.

samdaseuss

안녕하세요,

결과값이 영어로 잘 반환되는 것을 확인했습니다.

수고하셨습니다 :)👍

LEE1026icarus added 4 commits January 7, 2025 14:25

[Team] New content development Team3

976b0c7

[Title] UpstageEmbeddings [Version] initial [Language] ENG [Packages] dotenv, langchain_upstage, numpy - Langchain and UpstageEmbeddings Tutorial - A tutorial on using Langchain's class to access UpstageEmbeddings.

Merge branch 'main' of https://github.com/LEE1026icarus/LangChain-Ope…

da591ba

…nTutorial

Merge remote-tracking branch 'upstream/main' into LEE1026icarus-main

0b5e5c3

LEE1026icarus requested review from sunworl and samdaseuss January 9, 2025 03:21

teddylee777 requested a review from changwonjeon January 9, 2025 13:39

sunworl reviewed Jan 9, 2025

View reviewed changes

samdaseuss requested changes Jan 9, 2025

View reviewed changes

sunworl self-requested a review January 9, 2025 14:47

sunworl requested changes Jan 9, 2025

View reviewed changes

LEE1026icarus added 2 commits January 10, 2025 11:52

Merge remote-tracking branch 'upstream/main' into LEE1026icarus-main

2906622

Modify file based on reviewer feedback

a3baf74

LEE1026icarus requested review from samdaseuss and sunworl January 10, 2025 03:29

LEE1026icarus added 2 commits January 10, 2025 17:23

Merge remote-tracking branch 'upstream/main' into LEE1026icarus-main

31278bf

modified 12-RAG/assets/12-rag-rag-basic-pdf-rag-process-02.png

19f2bf2

changwonjeon reviewed Jan 10, 2025

View reviewed changes

samdaseuss requested changes Jan 11, 2025

View reviewed changes

12-RAG/01-RAG-Basic-PDF.ipynb Show resolved Hide resolved

sunworl added 2 commits January 11, 2025 15:00

Update 01-RAG-Basic-PDF.ipynb

821abbd

Environment-setup 텍스트 수정

Update 01-RAG-Basic-PDF.ipynb

73bdfd9

"LANGCHAIN_PROJECT": "RAG-Basic-PDF" 수정했습니다.

Update 12-RAG/01-RAG-Basic-PDF.ipynb

e0145a5

remove the () Co-authored-by: Jeon Changwon <[email protected]>

LEE1026icarus commented Jan 11, 2025

View reviewed changes

LEE1026icarus added 2 commits January 11, 2025 16:14

Rename 12-rag-rag-basic-pdf-rag-graphic-2.png to 12-rag-rag-basic-pdf…

622dd1c

…-rag-graphic-02.png Rename Image 2

Rename 12-rag-rag-basic-pdf-rag-graphic-1.png to 12-rag-rag-basic-pdf…

70939b5

…-rag-graphic-01.png Rename Image 1

Update 01-RAG-Basic-PDF.ipynb

f77c12c

TOC 수정

LEE1026icarus requested review from changwonjeon and samdaseuss January 11, 2025 07:25

LEE1026icarus and others added 2 commits January 11, 2025 16:29

Update 12-RAG/01-RAG-Basic-PDF.ipynb

51e6e6b

"# Create a prompt.\n", removed Co-authored-by: Jeon Changwon <[email protected]>

Update 12-RAG/01-RAG-Basic-PDF.ipynb

be21a25

"# Step 7: Create Language Model (LLM)\n" remove. Co-authored-by: Jeon Changwon <[email protected]>

sunworl previously approved these changes Jan 11, 2025

View reviewed changes

Update 01-RAG-Basic-PDF.ipynb

5a1e72f

오타가 있어서 수정했습니다.

sunworl dismissed their stale review via 5a1e72f January 11, 2025 09:15

sunworl approved these changes Jan 11, 2025

View reviewed changes

samdaseuss approved these changes Jan 11, 2025

View reviewed changes

teddylee777 merged commit af821fa into LangChain-OpenTutorial:main Jan 11, 2025
1 of 2 checks passed

sohyunwriter added the docs tutorial label Jan 18, 2025

[E-3] 12-RAG / 01-RAG-Basic-PDF.ipynb #284

[E-3] 12-RAG / 01-RAG-Basic-PDF.ipynb #284

Uh oh!

Conversation

LEE1026icarus commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Author Checklist

Review Template (Intial PR)

Uh oh!

sunworl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sunworl Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

sunworl Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

sunworl Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

sunworl Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sunworl Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

sunworl Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

sunworl Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sunworl Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

samdaseuss left a comment

Choose a reason for hiding this comment

Uh oh!

sunworl left a comment

Choose a reason for hiding this comment

Uh oh!

LEE1026icarus commented Jan 9, 2025

Uh oh!

LEE1026icarus commented Jan 10, 2025

Uh oh!

LEE1026icarus commented Jan 10, 2025

Uh oh!

changwonjeon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

[Review Checklist]

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sunworl commented Jan 10, 2025

Uh oh!

samdaseuss left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sunworl commented Jan 11, 2025

Uh oh!

LEE1026icarus left a comment

Choose a reason for hiding this comment

Uh oh!

sunworl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

LEE1026icarus commented Jan 9, 2025 •

edited

Loading

sunworl left a comment •

edited

Loading

sunworl Jan 9, 2025 •

edited

Loading

changwonjeon left a comment •

edited

Loading

samdaseuss left a comment •

edited

Loading

sunworl left a comment •

edited

Loading

samdaseuss left a comment •

edited

Loading