[E-4] 05-Memory / 03-ConversationTokenBufferMemory #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for PR proofreading
ee-juni
requested changes
Jan 9, 2025
Environement > Environment
|
Table of Contents 내용 수정했습니다. 꼼꼼하게 봐 주셔서 너무 감사 합니다. |
chaeyoonyunakim
previously approved these changes
Jan 9, 2025
BokyungisaGod
previously approved these changes
Jan 10, 2025
The merge-base changed after approval.
|
안녕하세요 @gyjong님, 모든 검토 및 2 approvals 이후 머지대기였던 PR에 변경사항이 생겨 알림 드립니다. 확인 후 Conflict resolve 요청드려요. 감사합니다 |
|
감사 합니다. 제가 빨리 확인하고 조치 취하도록 하겠습니다. |
ee-juni
requested changes
Jan 11, 2025
|
@chaeyoonyunakim 님 주말에도 알려 주셔서 감사 합니다. |
ee-juni
approved these changes
Jan 13, 2025
|
네 잘 해결된 것 같습니다! @BokyungisaGod 최종 approval 부탁드립니다~ |
BokyungisaGod
approved these changes
Jan 13, 2025
4f01fcb
into
LangChain-OpenTutorial:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Proofread: < 05-Memory / 03-ConversationTokenBufferMemory > #184
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.