Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

XaviereKU
Copy link
Contributor

[E-3] 04-Model/03-Cache

Seperated local llm serving tutorial

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

teddylee777 and others added 6 commits January 6, 2025 01:44
[Sync Fork] Sync Fork Process 1/6
Neo4j tutorial draft

To do :
- override langchain_neo4jvector.Neo4jVector to implement delete method, batch update method
- Add detailed explanation about Neo4j ( What is index, node, e.t.c.)
- Add multimodal example
- Add metadata filtering example
- Change example dataset for text only data
change neo4j host url
Separate the case with local llm serving
@teddylee777
Copy link
Contributor

@XaviereKU 님 지금 File 에 Neo-4j 파일이 같이 commit 된 것 같아요~ 확인 부탁 드립니다.

@XaviereKU
Copy link
Contributor Author

@XaviereKU 님 지금 File 에 Neo-4j 파일이 같이 commit 된 것 같아요~ 확인 부탁 드립니다.

해당 파일 옮겨두고 파일 삭제 상태에 대한걸 커밋을 안쳤습니다. 다시 옮겨두고 커밋 하였습니다.

@teddylee777 teddylee777 added the proofreading 번역/검수팀 제안사항 반영 label Jan 12, 2025
@teddylee777 teddylee777 requested review from teddylee777 and removed request for teddylee777 January 12, 2025 11:36
@Two-Jay
Copy link

Two-Jay commented Jan 12, 2025

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • Image: Image filenames follow guidelines.
  • *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:

안녕하세요. @XaviereKU님. 우선 작업 정말 잘 해주셔서 감사드립니다.

아래와 같은 수정사항만 반영되면 좋을 것 같아 전달드립니다.

  1. 아래의 모듈 설치 명령어에서 '!'을 '%'로 바꾸어주세요.

origin text

 %%capture --no-stderr
!pip install langchain-opentutorial

recommandation

 %%capture --no-stderr
%pip install langchain-opentutorial
  1. 코드에 대한 설명문에서 두 파일 모두, 파이썬 구현체, 모듈, 함수명에 대해 백틱 처리를 부탁드립니다. 예를 들어 아래와 같은 케이스가 발견되었습니다. 번역도 가능하다면 수정을 부탁드립니다.

origin text

Note that if we use SQLite Cache, setting caching again does not delete store cache

recommandation

Note that if we use `SQLiteCache`, setting caching again does not delete the stored caches.
  1. ToC 의 링크도 잘 작동하는 지 확인 부탁드립니다.

  2. 레퍼런스에 이번에 활용하신 SQLiteCache와 InMemoryCache의 레퍼런스도 추가를 부탁드립니다. 링크는 하기와 같습니다.

SQLiteCache :
https://python.langchain.com/api_reference/community/cache/langchain_community.cache.SQLiteCache.html#langchain_community.cache.SQLiteCache
InMemoryCache : https://python.langchain.com/api_reference/community/cache/langchain_community.cache.InMemoryCache.html#langchain_community.cache.InMemoryCache

  1. 04-Model/03-Cache 파일에서 strerr 로 오류로 나온 부분에 대해서 삭제하여주시고, 아래와 같이 정상적으로 출력이 된 부분만 남겨주시길 부탁드립니다. (시인성 개선을 목적으로 합니다.)
South Korea is a highly developed country in East Asia known for its technological advancements, vibrant culture, and economic prosperity. It has a rich history, beautiful landscapes, and a strong emphasis on education. The country is also a major player in the global economy and a leading exporter of electronics, automobiles, and other goods.
CPU times: total: 46.9 ms
Wall time: 1.2 s

ToC link check
Add references
Clear warning outputs
@Two-Jay
Copy link

Two-Jay commented Jan 12, 2025

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • Image: Image filenames follow guidelines.
  • *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: 수정사항 모두 확인하였고, 정상적으로 작성되었음을 확인하였습니다. 번거로운 작업이었을텐데 끝까지 고생 많으셨습니다. 앞으로도 화이팅입니다.

@teddylee777 teddylee777 merged commit 8282a10 into LangChain-OpenTutorial:main Jan 13, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants