Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[E-1] 01-Basic/05-Using-OpenAIAPI-MultiModal #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

[E-1] 01-Basic/05-Using-OpenAIAPI-MultiModal #313

merged 2 commits into from
Jan 14, 2025

Conversation

ErikaPark
Copy link
Contributor

@BokyungisaGod

최근 버전으로 업데이트 한 파일입니다.
(리뷰어 두 분께 리뷰를 받은 후 통과가 되었지만 (이전 PR) 수정 전 버전으로 돌아가서 다시 업로드 하는 파일입니다 !)
기존 버전에서 추가된 설명이 꽤 많아 번역/검수가 필요합니다.
이번 PR에서는 우선 보경님만 리뷰어로 추가하였습니다!

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

@teddylee777 teddylee777 changed the title E-1] 01-Basic/05-Using-OpenAIAPI-MultiModal [E-1] 01-Basic/05-Using-OpenAIAPI-MultiModal Jan 12, 2025
@BokyungisaGod BokyungisaGod requested a review from Q0211 January 12, 2025 12:53
@BokyungisaGod
Copy link
Contributor

@ErikaPark 연서님~~ 올려주신 파일 잘 확인했습니다!
스크린샷 2025-01-12 오후 10 04 09
사진 보시면 1번에 example : "The capital of South Korea is Seoul."
2번에 finish_reason: ~("stop" for normal completion)
에서 "The capital of South Korea is Seoul." 와 stop으로 바꿔주시면 감사하겠습니다!

이 부분만 고쳐서 올려주시면 approve하겠습니다!!

@ErikaPark
Copy link
Contributor Author

@ErikaPark 연서님~~ 올려주신 파일 잘 확인했습니다! 스크린샷 2025-01-12 오후 10 04 09 사진 보시면 1번에 example : "The capital of South Korea is Seoul." 2번에 finish_reason: ~("stop" for normal completion) 에서 "The capital of South Korea is Seoul." 와 stop으로 바꿔주시면 감사하겠습니다!

이 부분만 고쳐서 올려주시면 approve하겠습니다!!

빠른 답변 감사드립니다!! 아래와 같이 고쳐서 커밋하였습니다 ㅎㅎ
스크린샷 2025-01-12 오후 11 06 25

BokyungisaGod
BokyungisaGod approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@BokyungisaGod BokyungisaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 수고하셨습니다 연서님:)

@teddylee777 teddylee777 merged commit f628ef1 into LangChain-OpenTutorial:main Jan 14, 2025
3 of 4 checks passed
@sohyunwriter sohyunwriter added the docs tutorial label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Q0211 Q0211 Q0211 approved these changes

@BokyungisaGod BokyungisaGod BokyungisaGod approved these changes

Assignees
No one assigned
Labels
docs tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ErikaPark @BokyungisaGod @Q0211 @teddylee777 @sohyunwriter