[E-4] 15-Agent / 10-TwoAgentDebateWithTools #316

suhyun0115 · 2025-01-12T11:52:25Z

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

…torial

Secludor · 2025-01-16T09:14:09Z

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
- ### 헤더는 TOC에 링크를 두지 않기로 했던 것 같은데 확인이 필요합니다.
- 최상단 제목이 'Title' 로 되어 있습니다!
- References의 LangChain Tools Documentation 링크가 최신 문서가 아닙니다.
- 해더에서는 모듈을 백쿼토 ( ` ) 로 감싸지 않는다고 합니다.
- Internet Search Tool - Tavily 의 주석이 한글로 달려 있습니다.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.(N/A)
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- DialogueAgent 첫 코드 블럭에서
  - from langchain.schema import AIMessage, .. -> from langchain_core.messages import AIMessage, ..
- Document Search Tool Setup 첫 코드 블럭에서 :
  - from langchain.document_loaders import TextLoader -> from langchain_community.document_loaders import TextLoader
  - (다음 블럭) from langchain.tools.retriever import create_retriever_tool -> from langchain_core.tools.retriever import create_retriever_tool
Code Execution: Code runs without errors.
- 모든 셀이 실행되지만 Topic Specification 의 코드 블럭에서 다음의 메세지가 출력됩니다.
  - LangChainDeprecationWarning: The method BaseChatModel.call was deprecated in langchain-core 0.1.7 and will be removed in 1.0. Use :meth:~invoke instead.
Comments: {Write freely, 한국어 기술 가능}

suhyun0115 · 2025-01-16T14:00:26Z

@Secludor 헉 놓친게 많네요ㅠㅠ수정했습니다!! 다시 한번만 리뷰 부탁드립니다!감사합니다

- re-apply back quote - update import statements

Secludor · 2025-01-16T23:33:40Z

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
- 헤더에 모듈, 클래스가 포함된 경우 백쿼토로 감싸는 것으로 다시 합의가 된 것 같습니다..! 번거롭게 해드렸네요 ;ㅂ;
- 혹시 Two Agent Debate with Tools를 타이틀과 파일명에서 카멜 케이스로 하신 이유가 있나요?
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.(N/A)
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
~~- DialogueAgent 첫 코드 블럭에서
- from langchain.schema import AIMessage, .. -> from langchain_core.messages import AIMessage, ..~~
  ~~- Document Search Tool Setup 첫 코드 블럭에서 :
- from langchain.document_loaders import TextLoader -> from langchain_community.document_loaders import TextLoader
- (다음 블럭) from langchain.tools.retriever import create_retriever_tool -> from langchain_core.tools.retriever import create_retriever_tool~~
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
- 제가 발견한 부분들에 대해 import 최신화, 백쿼토 재적용 완료했습니다!
- 긴 분량 고생하셨습니다 :)

harheem

🖥️ OS: Win/Mac/Linux
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: 상세하고 좋은 튜토리얼인 것 같습니다! 고생하셨습니다 :)

suhyun0115 and others added 13 commits January 6, 2025 00:52

[N-1] 13-LangChain-Expression-Language / 01-RunnablePassthrough

576f351

Merge branch 'LangChain-OpenTutorial:main' into main

1047f9d

Delete 13-LangChain-Expression-Language/01-RunnablePassthrough.ipynb

d0fc4f7

Merge remote-tracking branch 'upstream/main'

3262b13

Merge branch 'LangChain-OpenTutorial:main' into main

d6643da

Resolve merge conflict

9792459

[E-4] 16-Evaluations / 10-Two-Agent-Debate-With-Tools

7317c54

Merge branch 'main' of https://github.com/suhyun0115/LangChain-OpenTu…

9f66867

…torial

Merge branch 'LangChain-OpenTutorial:main' into main

16e071d

Delete 06-DocumentLoader/06-WordLoader.ipynb.ipynb

2597ef5

Delete 16-Evaluations/10-Two-Agent-Debate-With-Tools.ipynb

02ebc1b

Delete 16-Evaluations/data directory

9e55787

[E-4] 15-Agent / 10-TwoAgentDebateWithTools

d12f393

suhyun0115 requested a review from harheem January 12, 2025 11:53

Merge branch 'LangChain-OpenTutorial:main' into main

820a55a

suhyun0115 requested a review from Secludor January 13, 2025 13:27

[E-4] 15-Agent / 10-TwoAgentDebateWithTools

08b0baf

docs : address pr review comments

b0dc9ab

- re-apply back quote - update import statements

Secludor approved these changes Jan 16, 2025

View reviewed changes

harheem approved these changes Jan 17, 2025

View reviewed changes

teddylee777 merged commit deb832b into LangChain-OpenTutorial:main Jan 18, 2025
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[E-4] 15-Agent / 10-TwoAgentDebateWithTools #316

[E-4] 15-Agent / 10-TwoAgentDebateWithTools #316

Uh oh!

suhyun0115 commented Jan 12, 2025 •

edited

Loading

Uh oh!

Secludor commented Jan 16, 2025 •

edited

Loading

Comments: {Write freely, 한국어 기술 가능}

Uh oh!

suhyun0115 commented Jan 16, 2025

Uh oh!

Secludor commented Jan 16, 2025 •

edited

Loading

Uh oh!

harheem left a comment

Uh oh!

Uh oh!

Uh oh!

[E-4] 15-Agent / 10-TwoAgentDebateWithTools #316

[E-4] 15-Agent / 10-TwoAgentDebateWithTools #316

Uh oh!

Conversation

suhyun0115 commented Jan 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Author Checklist

Review Template (Intial PR)

Uh oh!

Secludor commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments: {Write freely, 한국어 기술 가능}

Uh oh!

suhyun0115 commented Jan 16, 2025

Uh oh!

Secludor commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harheem left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

suhyun0115 commented Jan 12, 2025 •

edited

Loading

Secludor commented Jan 16, 2025 •

edited

Loading

Secludor commented Jan 16, 2025 •

edited

Loading