[E-1] 10-Retriever / 08-SelfQueryRetriever #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Title] Self-querying [Version] initial [Language] ENG [Packages] langchain.chains.query_constructor, langchain.retrievers.self_query, langchain_chroma, langchain_openai
[Title] Self-querying [Version] initial [Language] ENG [Packages] langchain.chains.query_constructor, langchain.retrievers.self_query, langchain_chroma, langchain_openai
[Title] Prompt Template [Version] revision [Language] ENG [Packages] langchain_core.prompts, langchain_openai
[Title] Self-querying [Version] revision [Language] ENG [Packages] langchain.chains.query_constructor, langchain.retrievers.self_query, langchain_chroma, langchain_openai
[Title] Self-querying [Version] revision [Language] ENG [Packages] langchain.chains.query_constructor, langchain.retrievers.self_query, langchain_chroma, langchain_openai
[Title] Self-querying [Version] revision [Language] ENG [Packages] langchain.chains.query_constructor, langchain.retrievers.self_query, langchain_chroma, langchain_openai
[Title] Self-querying [Version] revision [Language] ENG [Packages] langchain.chains.query_constructor, langchain.retrievers.self_query, langchain_chroma, langchain_openai
[Title] Self-querying [Version] revision [Language] ENG [Packages] langchain.chains.query_constructor, langchain.retrievers.self_query, langchain_chroma, langchain_openai
[Title] Self-querying [Version] revision [Language] ENG [Packages] langchain.chains.query_constructor, langchain.retrievers.self_query, langchain_chroma, langchain_openai
This reverts commit 5a376f7.
harheem
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
π₯οΈ OS: Mac
β
Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: ν¨ν€μ§ μ΄μλ‘ μ΄λ €μμ΄ λ§μΌμ ¨μ ν λ° λκΉμ§ ν΄κ²°ν΄ λ΄μ κ² μ λ§ λλ¨νμλλ€. νν 리μΌλ λꡬλ μ½κ² μ΄ν΄ν μ μλλ‘ μ μ±μ€λ½κ² μμ±ν΄ μ£Όμ ¨λ€μ! λ€λ₯Έ κ°λ°μλΆλ€μκ²λ μ’μ νμ΅ μλ£κ° λ κ² κ°μ΅λλ€. μ λ λ€μ μ½ν μΈ μ€λΉν λ λ§μ μκ°μ μ»μμ΄μ. κ°μ¬ν©λλ€ :)
sirena1
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
[Review Checklist]
-
Review OS:
- Windows
-
Template Rule μ€μ μ¬λΆ:
- Template Rule κ°μ΄λλ₯Ό μ€μνμλκ°? (Check νκΈ°)
-
Table of Contents λ§ν¬ νμΈ:
- Table of Contentsμ λ§ν¬κ° μννκ² λμνλμ§ νμΈνμλκ°? (Check νκΈ°)
-
μ΄λ―Έμ§ νμΌλͺ κ²ν :
- μ΄λ―Έμ§κ° ν¬ν¨λμ΄ μλ€λ©΄, μ΄λ―Έμ§μ νμΌλͺ μ΄ κ°μ΄λλ₯Ό μ€μνμλκ°? (Check νκΈ°)
-
μ΅μ import λ°©μ μ¬μ© μ¬λΆ:
- import κ΅¬λ¬Έμ΄ μμ legacy λ°©μμ΄ μλ μ΅μ λ²μ μ λ°λ₯΄λκ°? (Check νκΈ°)
-
μ½λ λμ νμΈ:
- λͺ¨λ μ½λκ° μ€λ₯ μμ΄ λμνλκ°? (Check νκΈ°)
- Warning λ°μ μ μ½λ©νΈμ μ μ΄μ£ΌμΈμ.
-
μ μΆ νμΌ νμΈ:
- κΌ νμν νμΌλ€λ§ μ μΆλμλκ°?
- νν λ¦¬μΌ μΈ μ€μ νμΌμ΄λ λ€λ₯Έ λΆμ΄ μμ ν νμΌμ΄ ν¬ν¨λμλμ§ Files Changedμμ νμΈ λΆνλ립λλ€. (Check νκΈ°)
- κΌ νμν νμΌλ€λ§ μ μΆλμλκ°?
-
κΈ°ν μ견:
κ³ μ λ§μΌμ ¨μ΅λλ€ :)
7aa3cc2
into
LangChain-OpenTutorial:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynbΒ #123)
β Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N