Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Hye-yoonJeong
Copy link
Contributor

[Title] Prompt Template
[Version] revision
[Language] ENG
[Packages] langchain_core.prompts, langchain_openai

1주차 검수 내용 반역

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

[Title] Prompt Template
[Version] revision
[Language] ENG
[Packages] langchain_core.prompts, langchain_openai
@BokyungisaGod
Copy link
Contributor

BokyungisaGod commented Jan 13, 2025

@Hye-yoonJeong 님 안녕하세요~ 수정 반영해주신 파일 잘 봤습니다.
몇가지 수정사항이 있어서 안내드립니다!

  1. Overview에 ~using LangChain을 ~using LangChain으로 바꿔주세요!
스크린샷 2025-01-13 오후 1 42 23
  1. Table of Contents에는 backtick 처리를 따로 하지 않습니다!
스크린샷 2025-01-13 오후 1 47 41

이 부분만 고쳐주시면 될 것 같습니다 :)

@Hye-yoonJeong
Copy link
Contributor Author

Hye-yoonJeong commented Jan 13, 2025

TOC의 backtick과 관련하여 질문이 하나 더 있습니다! 헤더에도 backtick을 적용하지 않는 것이 맞나요? 아니면 헤더에는 backtick을 쓰고 TOC에만 안 쓰는 것인가요?

@BokyungisaGod
Copy link
Contributor

@Hye-yoonJeong 확인이 늦었네요ㅜㅜ 죄송합니다. TOC, 헤더 둘 다 쓰지 않는 것이 맞습니다!

[Title] Prompt Template
[Version] revision
[Language] ENG
[Packages] langchain_core.prompts, langchain_openai
@Hye-yoonJeong
Copy link
Contributor Author

@Hye-yoonJeong 확인이 늦었네요ㅜㅜ 죄송합니다. TOC, 헤더 둘 다 쓰지 않는 것이 맞습니다!

수정하여 커밋하였습니다! :)

Copy link
Contributor

@BokyungisaGod BokyungisaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~ 수고하셨습니다:)

@teddylee777 teddylee777 merged commit 906ae1e into LangChain-OpenTutorial:main Jan 14, 2025
1 check failed
@Hye-yoonJeong Hye-yoonJeong deleted the week1 branch January 20, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants