[E-2] 16-Evaluations / 02-Evaluation using RAGAS #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samdaseuss @architectyou Peer Review 란에 이름을 github 참고해서 기입했는데 확인해주시길 바랍니다 :D |
samdaseuss
reviewed
Jan 16, 2025
There was a problem hiding this comment.
🖥️ OS: Win/Mac/Linux
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports(: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
안녕하세요,
코드는 정상적으로 동작하나 주석 몇개가 번역이 안된 것을 확인하였습니다.
LaTeX 문법으로 복잡한 수식 작성하시느라 정말 고생 많으셨습니다 :)
감사합니다.
| " context_precision,\n", | ||
| ")\n", | ||
| "\n", | ||
| "# 데이터셋 형식 맞추기\n", |
| " }\n", | ||
| " formatted_dataset.append(formatted_item)\n", | ||
| "\n", | ||
| "# RAGAS 데이터셋으로 변환\n", |
TODO: - change a base pdf file - rerun all cells to update outputs
327ceb5 to
eb449f2
Compare
architectyou
previously approved these changes
Jan 17, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports(: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: 작성하시느라 고생 많으셨습니다! 전체적으로 깔끔하게 잘 작성된 것 같습니다! 내용도 풍부하고 수식 작성하시느라 정말 고생 많으셨을 것 같습니다 ㅠㅠ 앞서 말씀드린 소제목 링크를 reference 목차로 다 빼는 게 좋겠다는 의견 외에 모두 정상동작합니다!
|
수고하셨습니다:) |
samdaseuss
approved these changes
Jan 17, 2025
c095bc6
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N