Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Proofread: < 03-OutputParser / 04-JsonOutputParser > #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

Proofread: < 03-OutputParser / 04-JsonOutputParser > #342

merged 1 commit into from
Jan 14, 2025

Conversation

ash-hun
Copy link
Contributor

@ash-hun ash-hun commented Jan 13, 2025

Proofread: < 03-OutputParser / 04-JsonOutputParser > #191 내용 수정/반영하여 PR 올립니다.

번역/검수팀 너무 고생많으시고 최대한 빨리 하려고 했는데 이제서야 제대로 PR드리게 되어 죄송스러운 마음뿐입니다😂
검토 부탁드리겠습니다!!

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@ash-hun ash-hun self-assigned this Jan 13, 2025
BokyungisaGod
BokyungisaGod approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@BokyungisaGod BokyungisaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다~ 수고하셨습니다:)

ee-juni
ee-juni approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@ee-juni ee-juni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 수고하셨습니다~

@ash-hun
Copy link
Contributor Author

ash-hun commented Jan 14, 2025

해당 내용에 대한 Issue #191 는 제가 닫지 않고 그냥둬도 되는건가요?

@ee-juni ee-juni added the proofreading 번역/검수팀 제안사항 반영 label Jan 14, 2025
@ee-juni
Copy link
Contributor

ee-juni commented Jan 14, 2025

저는 최종 PR merge까지 완료되면 이슈 닫는데, 아직 확실히 정해진 규칙이 있는지는 저도 헷갈리네요

@teddylee777 teddylee777 merged commit 6e8344d into LangChain-OpenTutorial:main Jan 14, 2025
0 of 2 checks passed
@teddylee777
Copy link
Contributor

@ash-hun @ee-juni PR merge는 Reviewer 분들 approve 나도 통상 24시간 이후 merge 가 가능한데요. 제가 수작업으로 확인하고 빨리 닫고 있습니다^^

저에게 노티 주시면 확인 후 더 빨리 닫겠습니다!

다들 고생이 많으십니다 ㅠ

@ash-hun
Copy link
Contributor Author

ash-hun commented Jan 14, 2025

ㅎㅎ 알려주셔서 감사합니다😊

@ash-hun ash-hun deleted the jsonoutputparser branch January 20, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ee-juni ee-juni ee-juni approved these changes

@BokyungisaGod BokyungisaGod BokyungisaGod approved these changes

Assignees

@ash-hun ash-hun

Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ash-hun @ee-juni @teddylee777 @BokyungisaGod