Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[N-1] 06-DocumentLoader / 06-WordLoader #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2025
Merged

[N-1] 06-DocumentLoader / 06-WordLoader #344

merged 4 commits into from
Jan 17, 2025

Conversation

suhyun0115
Copy link
Contributor

@suhyun0115 suhyun0115 commented Jan 13, 2025 •
edited
Loading

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Proofread: < 06-DocumentLoader / 06-WordLoader > Proofread: < 06-DocumentLoader / 06-WordLoader > #317)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. ((Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@teddylee777 teddylee777 added the proofreading 번역/검수팀 제안사항 반영 label Jan 13, 2025
@choincnp choincnp self-requested a review January 13, 2025 16:53
@BokyungisaGod
Copy link
Contributor

@suhyun0115 님 안녕하세요~
스크린샷 2025-01-14 오전 1 58 42
스크린샷 2025-01-14 오전 1 59 01
스크린샷 2025-01-14 오전 2 02 46

스크린샷을 보시면 ###으로 제목(?)을 적으셨는데, 아래 사진처럼
스크린샷 2025-01-14 오전 2 05 59
하위 카테고리에 콘텐츠를 작성하셔야 합니다. 작성 후 커밋 해주시면 approve 하겠습니다:)

@choincnp
Copy link
Contributor

수현님 화이팅~~

@suhyun0115
Copy link
Contributor Author

suhyun0115 commented Jan 14, 2025 •
edited
Loading

추가 수정 완료하였습니다!

@BokyungisaGod
Copy link
Contributor

안녕하세요 @suhyun0115 님~! 다른 부분은 잘 고쳐주신거 확인했습니다~ 근데 추가적으로 2개 정도 수정사항이 있어요ㅜㅜ
스크린샷 2025-01-15 오전 11 46 47
스크린샷 2025-01-15 오전 11 47 05
위에 제가 첨부해놓은 2개의 사진을 보시면 mode:Singe(default)와 mode:elements 앞에 있던 ###를 삭제하셨더라고요!
삭제를 하는 것은 상관없지만 저렇게 되면 아래에 대한 설명이 아니라 위에 대한 설명으로 혼란을 겪을 수도 있을 것 같아요.
###그대로 처리하되 아래 내용을 간단하게만 채워넣어 주시면 감사하겠습니다!!

@suhyun0115
Copy link
Contributor Author

반영 완료했습니다!

choincnp
choincnp approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@choincnp choincnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 :)!!

@teddylee777 teddylee777 merged commit ae8e92d into LangChain-OpenTutorial:main Jan 17, 2025
1 of 2 checks passed
@suhyun0115 suhyun0115 deleted the clean-fix-317 branch January 18, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choincnp choincnp choincnp approved these changes

@BokyungisaGod BokyungisaGod BokyungisaGod approved these changes

Assignees
No one assigned
Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suhyun0115 @BokyungisaGod @choincnp @teddylee777