[E-4] 15-Agent / 05-Iteration-HumanInTheLoop #347

BaBetterB · 2025-01-13T15:02:27Z

{PR Message - Write freely, remove this bracket if unnecessary}
[Title] Iteration-HumanInTheLoop
[Version] modified colab link
[Language] ENG
[Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

Author Checklist

PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

…ationFunction(Human-in-the-loop) [Version] initial commit [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

…ationFunction(Human-in-the-loop) [Version] modified colab link [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

…nTheLoop [Version] initial commit [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

…nTheLoop [Version] modified colab link [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

…nTheLoop [Version] delete teddy lib [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai

…vised version [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai

Secludor · 2025-01-16T09:47:53Z

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
- 혹시 제목에 Human-in-the-Loop 을 카멜 케이스로 하신 이유가 있나요? 모듈 이름이 아니기 때문에 카멜케이스, 백쿼토가 없어도 될 것 같습니다!
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.(N/A)
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
- 실행에는 문제가 없는데 AgentExecutor 의
  - 마크다운 블럭 2, 3번 단계가 덧셈이 잘못되었습니다. (235.7+32.2 = 269.9)
  - 코드 블럭의 실행에서 덧셈이 마크다운 내용과 다르게 단계별로 수행되지 않습니다.
    - Tool Name: add_function, Execution Result: 235.7
    - Tool Name: add_function, Execution Result: 380.0
    - The result of 114.5 + 121.2 + 34.2 + 110.1 is 380.0.
  - (제안) 중간 단계에서도 마크다운 블럭의 내용처럼 계산식이 표시되면 좋을 것 같습니다!
    - (예 : 1. 114.5 + 121.2 = 235.7)

ranian963

"LANGCHAIN_PROJECT": "Iteration Function and Human-in-the-loop", 에서 번호가 빠져 있는 것 같습니다.

Secludor · 2025-01-16T23:40:46Z

현재 PR에 Binding.ipynb가 함께 커밋되어 있습니다!

BaBetterB · 2025-01-17T00:27:29Z

현재 PR에 Binding.ipynb가 함께 커밋되어 있습니다!
공유 감사드립니다. 조치하겠습니다.

…d and revised version [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai" This reverts commit 46a0600.

…orial

…in-the-loop [Version] bug fix [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai

BaBetterB · 2025-01-17T07:42:06Z

🖥️ OS: Win ✅ Checklist

Template: Tutorials follows the required template.

혹시 제목에 Human-in-the-Loop 을 카멜 케이스로 하신 이유가 있나요? 모듈 이름이 아니기 때문에 카멜케이스, 백쿼토가 없어도 될 것 같습니다!

Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)

Image: Image filenames follow guidelines.(N/A)

*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.

Code Execution: Code runs without errors.

Comments: {Write freely, 한국어 기술 가능}

실행에는 문제가 없는데 AgentExecutor 의

마크다운 블럭 2, 3번 단계가 덧셈이 잘못되었습니다. (235.7+32.2 = 269.9)

코드 블럭의 실행에서 덧셈이 마크다운 내용과 다르게 단계별로 수행되지 않습니다.

Tool Name: add_function, Execution Result: 235.7

Tool Name: add_function, Execution Result: 380.0

The result of 114.5 + 121.2 + 34.2 + 110.1 is 380.0.

(제안) 중간 단계에서도 마크다운 블럭의 내용처럼 계산식이 표시되면 좋을 것 같습니다!

(예 : 1. 114.5 + 121.2 = 235.7)

자세한 검토와 제안 감사드립니다.

네 제목 부분은 의견 주신것을 반영하여 조정하였습니다~
다만 파일명과도 연동이 필요하기 때문에 proofread 시점에 최종 반영 하겠습니다.
백쿼토는 삭제하고 일반 구문처럼 바꾸었습니다.

네 마크다운 오타 수정반영하였습니다.
그리고 계산식이 단계별로 수행되지 않는 이유를 확인하는 과정에서
verbose=True로 실행해보니
계산식 1 , 2, 3 순차적으로 수행하지 않고
1단계 114.5 + 121.2 = 235.7, 34.2 + 110.1 = 144.3
2단계 235.7 + 144.3 = 380.0
방식으로 수행하는것으로 판단되어 아래와 같이 추가 내용을 기입해두었습니다. ^^
In practice, while calculating 114.5 + 121.2 = 235.7, 34.2 + 110.1 = 144.3 is also calculated simultaneously.

Then, the result of 235.7 + 144.3 = 380.0 is calculated as the second step.

This process can be observed when verbose=True is set in the AgentExecutor.

…in-the-loop [Version] bug fix [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai

BaBetterB · 2025-01-17T07:45:44Z

"LANGCHAIN_PROJECT": "Iteration Function and Human-in-the-loop", 에서 번호가 빠져 있는 것 같습니다.

title 부분은 아마도 번호 기입하지 않는것으로 가이드 된 것 같습니다
"LANGCHAIN_PROJECT": "Iteration-human-in-the-loop" 로 수정하였습니다.

Secludor · 2025-01-17T12:52:49Z

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.(N/A)
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
- 아 그런 이유였군요! 확인해주셔서 감사합니다 :)
- 이번주도 고생하셨습니다 👍

ranian963

🖥️ OS: Mac
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
Image: Image filenames follow guidelines.(N/A)
*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
- 잘 동작하는 것을 확인하였습니다.
- 다만, 제가 맥과 코랩에서 확인을 하였는데 코랩에서 확인시 dotenv 모듈이 없다고 에러가 납니다. langchain_community 패키지나 dotenv 패키지가 인스톨 패키지에 추가되어야 할것 같습니다.

…in-the-loop [Version] bug fix-add import lib [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_community,load_dotenv,langchain_openai

BaBetterB · 2025-01-18T06:08:34Z

🖥️ OS: Mac ✅ Checklist

Template: Tutorials follows the required template.

Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)

Image: Image filenames follow guidelines.(N/A)

*Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.

Code Execution: Code runs without errors.

Comments: {Write freely, 한국어 기술 가능}

잘 동작하는 것을 확인하였습니다.

다만, 제가 맥과 코랩에서 확인을 하였는데 코랩에서 확인시 dotenv 모듈이 없다고 에러가 납니다. langchain_community 패키지나 dotenv 패키지가 인스톨 패키지에 추가되어야 할것 같습니다.

@ranian963 님 상세한 리뷰 감사드립니다.
package.install(
[
"langsmith",
"langchain",
"langchain_core",
"langchain_community",
"load_dotenv",
"langchain_openai",
],
verbose=False,
upgrade=False,
)와 같이 수정하였습니다~

Secludor

🖥️ OS: Win
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
- 이번주도 고생하셨습니다 !!

ranian963

🖥️ OS: Mac
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}
- 수정 확인하였습니다.
- 고생 많으셨습니다!

BaBetterB added 9 commits January 13, 2025 22:12

[E-4] 15-Agent / 05-IterationFunction(Human-in-the-loop) [Title] Iter…

e8b7652

…ationFunction(Human-in-the-loop) [Version] initial commit [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

[E-4] 15-Agent / 05-IterationFunction(Human-in-the-loop) [Title] Iter…

272637e

…ationFunction(Human-in-the-loop) [Version] modified colab link [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

[E-4] 15-Agent / 05-IterationFunction(Human-in-the-loop) [Title] Iter…

3b3107f

…ationFunction(Human-in-the-loop) [Version] modified colab link [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

[E-4] 15-Agent / 05-IterationFunction(Human-in-the-loop) [Title] Iter…

74e38bd

…ationFunction(Human-in-the-loop) [Version] modified colab link [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

[E-4] 15-Agent / 05-IterationFunction(Human-in-the-loop) [Title] Iter…

0c8f3d8

…ationFunction(Human-in-the-loop) [Version] modified colab link [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop [Title] Iteration-HumanI…

f79fc65

…nTheLoop [Version] initial commit [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop [Title] Iteration-HumanI…

e8fbb06

…nTheLoop [Version] modified colab link [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai,langchain_teddynote

Merge remote-tracking branch 'upstream/main'

8c123ca

file delete

d9f5bf3

BaBetterB requested review from ranian963 and Secludor January 13, 2025 15:02

BaBetterB self-assigned this Jan 13, 2025

BaBetterB added 4 commits January 15, 2025 16:45

Merge branch 'LangChain-OpenTutorial:main' into main

566952a

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop [Title] Iteration-HumanI…

85854ff

…nTheLoop [Version] delete teddy lib [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai

[E-4] 13-LCEL / 10-Binding [Title] Binding [Version] Proofread and re…

46a0600

…vised version [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai

Merge branch 'LangChain-OpenTutorial:main' into main

5af1aca

ranian963 reviewed Jan 16, 2025

View reviewed changes

BaBetterB added 5 commits January 17, 2025 10:39

Merge branch 'LangChain-OpenTutorial:main' into main

f1ecedb

Revert "[E-4] 13-LCEL / 10-Binding [Title] Binding [Version] Proofrea…

97791c8

…d and revised version [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai" This reverts commit 46a0600.

Merge branch 'main' of https://github.com/BaBetterB/LangChain-OpenTut…

873196c

…orial

Merge remote-tracking branch 'upstream/main'

fa5144b

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop [Title] Iteration-human-…

8bc9bc2

…in-the-loop [Version] bug fix [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop [Title] Iteration-human-…

e19117f

…in-the-loop [Version] bug fix [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_openai

Secludor previously approved these changes Jan 17, 2025

View reviewed changes

ranian963 self-requested a review January 18, 2025 02:20

ranian963 reviewed Jan 18, 2025

View reviewed changes

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop [Title] Iteration-human-…

ed0c21a

…in-the-loop [Version] bug fix-add import lib [Language] ENG [Package] langsmith,langchain,langchain_core,langchain_community,load_dotenv,langchain_openai

BaBetterB dismissed Secludor’s stale review via ed0c21a January 18, 2025 06:05

Secludor approved these changes Jan 18, 2025

View reviewed changes

ranian963 self-requested a review January 18, 2025 11:13

ranian963 approved these changes Jan 18, 2025

View reviewed changes

teddylee777 merged commit f8ebb20 into LangChain-OpenTutorial:main Jan 18, 2025
1 of 2 checks passed

sohyunwriter added the docs tutorial label Jan 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop #347

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop #347

Uh oh!

BaBetterB commented Jan 13, 2025

Uh oh!

Secludor commented Jan 16, 2025 •

edited

Loading

Uh oh!

ranian963 left a comment

Uh oh!

Secludor commented Jan 16, 2025

Uh oh!

BaBetterB commented Jan 17, 2025

Uh oh!

BaBetterB commented Jan 17, 2025

Uh oh!

BaBetterB commented Jan 17, 2025

Uh oh!

Secludor commented Jan 17, 2025

Uh oh!

ranian963 left a comment

Uh oh!

BaBetterB commented Jan 18, 2025

Uh oh!

Secludor left a comment

Uh oh!

ranian963 left a comment

Uh oh!

Uh oh!

Uh oh!

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop #347

[E-4] 15-Agent / 05-Iteration-HumanInTheLoop #347

Uh oh!

Conversation

BaBetterB commented Jan 13, 2025

Author Checklist

Review Template (Intial PR)

Uh oh!

Secludor commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ranian963 left a comment

Choose a reason for hiding this comment

Uh oh!

Secludor commented Jan 16, 2025

Uh oh!

BaBetterB commented Jan 17, 2025

Uh oh!

BaBetterB commented Jan 17, 2025

Uh oh!

BaBetterB commented Jan 17, 2025

Uh oh!

Secludor commented Jan 17, 2025

Uh oh!

ranian963 left a comment

Choose a reason for hiding this comment

Uh oh!

BaBetterB commented Jan 18, 2025

Uh oh!

Secludor left a comment

Choose a reason for hiding this comment

Uh oh!

ranian963 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Secludor commented Jan 16, 2025 •

edited

Loading