[N-2] 09-Vector Store / 02-Chroma #367

pupba · 2025-01-14T18:25:13Z

File Name Changed.
I modified it to fit the template(Manage Store, upsert, upsert parallel, Multimodal Search).
Separate into base and multimodal cases.
ChromaDB Class was defined by Wrapping the langchain-chroma library.

Author Checklist

PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

- Notebook file Name Changed - Rebuild to template form(Add,Upsert,Delete,...) - Multimodal Partial Separation (Content to be modified)

- File Name Changed. - I modified it to fit the template. - Separate into base and multimodal cases. - `ChromaDB` Class was defined by Wrapping the `langchain-chroma` library.

namyoungkim · 2025-01-16T12:12:20Z

🖥️ OS: Mac
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments:
- 작성하시느라 고생하셨습니다!!
  - 도식화된 그림이 있어서 이해하는데 도움이 되었고
  - 추상 클래스 상속 받으셔서 ChromaDB, ChromaMulitmodalDB로 구현하셨네요
  - 멀티 모달용 데이터셋까지 👍👍
- .ipynb 2개 파일 모두 정상적으로 실행되는 것 확인했습니다.
- 02-Chroma.ipynb 리뷰
  - HUGGINGFACEHUB_API_TOKEN 도 set_env에 포함되면 좋을 것 같습니다~! (멀티모달에는 포함되어 있습니다.)
- 02-Chroma-Multimodal.ipynb 리뷰
  - 마크 다운 문법 관련 공지사항
    - 소제목에 백틱 사용하면 안된다고 공지사항이 떴습니다! (저도 백틱 많이 사용하는데, 백틱을 최소한으로 사용해야 할 것 같아요!)
    - 다음 부분에 포함되어 있어서 수정 요청드립니다!

수고 많으셨어요!
리뷰 내용 확인 부탁드리며, 파일 2개를 이번 PR에서 다 merge 할 것인 지는 한번 문의드려보면 좋을 것 같습니다!!
감사합니다~~

Normalist-K

🖥️ OS: Mac
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}

수고 많으셨습니다! 내용이 알차네요.

사소하게 수정해야할 것 있어 전달드립니다~

multimodal 노트북 파일에 Table of Contents 수정해야할 것 같습니다! 기존 내용 소제목이 링크되어있네요.
그리고 multimodal 노트북에 backtick 띄워쓰기 필요한 부분 알려드립니다~

- fixed : `02-Chroma.ipynb`, `02-Chroma-Multimodal.ipynb`

pupba · 2025-01-18T11:04:43Z

@namyoungkim

HUGGINGFACEHUB_API_TOKEN 추가
backtick 관련 내용 수정
2개의 파일 merge는 회식때 말씀드렸었고 이번에 진행 하는 것으로 했습니다!

@Normalist-K

Table of Content 수정
backtick 관련 내용 수정

꼼꼼한 Review 감사드립니다!
확인되시면 Approve 부탁 드립니다!

namyoungkim

🖥️ OS: Mac
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.

수정해주신 내용 확인했고, 코드 실행도 정상적으로 됩니다.
고생하셨습니다!

- Output 1~2개로 수정

pupba · 2025-01-18T13:05:19Z

@namyoungkim approve 부탁 드려요!

namyoungkim

🖥️ OS: Win/Mac/Linux
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments:

@pupba
광원님, dimension 에러가 발생합니다~!
확인부탁드립니다!! (_ _)

InvalidDimensionException: Embedding dimension 768 does not match collection dimensionality 512

namyoungkim

🖥️ OS: Win/Mac/Linux
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments:
두 노트북을 동시에 돌리면 에러가 나는 거였네요.
- 각 노트북 가장 아래 셀에서 디비 관련 정보를 삭제하기 때문에 별도로 실행하면 오류는 없지만, 이름을 다르게 짓는 것도 좋겠네요

Normalist-K

수고많으셨습니다!

pupba · 2025-01-18T13:38:07Z

@namyoungkim Chroma.ipynb에서 셀 실행시 data/chroma 디렉토리가 만들어집니다. 이후 Chroma-Multimodal.ipynb를 바로 실행하면 두 노트북에서 사용한 Embedding이 틀립니다.(하나는 알리바바 Text 전용, 하나는 OpenCLIP 이미지+텍스트 임베딩) 그리고 두 노트북 파일을 보면 DB 연결할 때 같은 파일을 참조합니다. Chroma는 기존 임베딩과 새로 추가하려는 임베딩의 차원이 다르면 오류가 발생합니다. 그래서 Chroma.ipynb를 다 실행하면 data/chroma에 있는 파일을 삭제해주셔야 Embedding 에러가 뜨지 않을꺼에요!!

namyoungkim · 2025-01-18T13:46:36Z

@pupba
상세한 설명 감사합니다!!
다음주 진행하실 때, 관련 내용을 설명으로 추가하거나, 코드를 넣어줘도 좋을 것 같습니다~!

data/chroma 폴더 하위 파일이 있으면 삭제하는 코드 (chromaDB 초기화)

고생하셨습니다~~!

- Collection 이름 수정

pupba · 2025-01-18T13:57:34Z

Mutimodal은 추후 다른 폴더로 빼기로 했어서, 그 부분을 제가 간과한것 같네요....! 일단 현상황에서는 에러가 발생할 수 있으니 Collection 이름을 변경하는 것으로 수정해 놓겠습니다.

namyoungkim

🖥️ OS: Win/Mac/Linux
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments:
- 감사합니다. Collection 이름 변경해주시니까 노트북 둘다 정상적으로 다 실행됩니다!
- 고생하셨어요~~!

pupba · 2025-01-18T18:04:45Z

@Normalist-K 제가 커밋하면서 approve 가 취소 되었네요 ㅠㅠ 번거로우시겠지만 다시 부탁 드립니다!!

sohyunwriter · 2025-01-18T22:56:44Z

🖥️ OS: �Mac
✅ Checklist

Template: Tutorials follows the required template.
Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
Image: Image filenames follow guidelines.
Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
Code Execution: Code runs without errors.
Comments: {Write freely, 한국어 기술 가능}

내용이 정말 알차네요!! 주피터노트북 출력 결과 적당한지 확인했습니다! 고생하셨습니다.

pupba added 5 commits January 14, 2025 03:42

[N-2] 09-Vector Store / 02-Chroma

34ac3e3

- Notebook file Name Changed - Rebuild to template form(Add,Upsert,Delete,...) - Multimodal Partial Separation (Content to be modified)

Merge branch 'LangChain-OpenTutorial:main' into dev-pupba-3week

08818b4

Merge branch 'LangChain-OpenTutorial:main' into dev-pupba-3week

622159f

[N-2] 09-Vector Store / 02-Chroma

b7fd81c

- File Name Changed. - I modified it to fit the template. - Separate into base and multimodal cases. - `ChromaDB` Class was defined by Wrapping the `langchain-chroma` library.

[N-2] 09-Vector Store / 02-Chroma

f912335

- File Name Changed. - I modified it to fit the template. - Separate into base and multimodal cases. - `ChromaDB` Class was defined by Wrapping the `langchain-chroma` library.

pupba added docs tutorial new tutorial suggestions labels Jan 14, 2025

pupba requested review from namyoungkim and Normalist-K January 14, 2025 18:25

Normalist-K requested changes Jan 17, 2025

View reviewed changes

sohyunwriter self-requested a review January 17, 2025 15:23

[N-2] 09-Vector Store / 02-Chroma

744b4ba

- fixed : `02-Chroma.ipynb`, `02-Chroma-Multimodal.ipynb`

namyoungkim previously approved these changes Jan 18, 2025

View reviewed changes

[N-2] 09-Vector Store / 02-Chroma

d91d7f2

- Output 1~2개로 수정

pupba dismissed namyoungkim’s stale review via d91d7f2 January 18, 2025 12:35

namyoungkim requested changes Jan 18, 2025

View reviewed changes

namyoungkim previously approved these changes Jan 18, 2025

View reviewed changes

Normalist-K previously approved these changes Jan 18, 2025

View reviewed changes

[N-2] 09-Vector Store / 02-Chroma

94a33e7

- Collection 이름 수정

pupba dismissed stale reviews from Normalist-K and namyoungkim via 94a33e7 January 18, 2025 13:57

namyoungkim approved these changes Jan 18, 2025

View reviewed changes

sohyunwriter approved these changes Jan 18, 2025

View reviewed changes

sohyunwriter merged commit ee9f9b7 into LangChain-OpenTutorial:main Jan 18, 2025
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[N-2] 09-Vector Store / 02-Chroma #367

[N-2] 09-Vector Store / 02-Chroma #367

Uh oh!

pupba commented Jan 14, 2025 •

edited

Loading

Uh oh!

namyoungkim commented Jan 16, 2025

Uh oh!

Normalist-K left a comment •

edited

Loading

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

namyoungkim left a comment

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

namyoungkim left a comment

Uh oh!

namyoungkim left a comment

Uh oh!

Normalist-K left a comment

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

namyoungkim commented Jan 18, 2025 •

edited

Loading

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

namyoungkim left a comment

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

sohyunwriter commented Jan 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[N-2] 09-Vector Store / 02-Chroma #367

[N-2] 09-Vector Store / 02-Chroma #367

Uh oh!

Conversation

pupba commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Author Checklist

Review Template (Intial PR)

Uh oh!

namyoungkim commented Jan 16, 2025

Uh oh!

Normalist-K left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

namyoungkim left a comment

Choose a reason for hiding this comment

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

namyoungkim left a comment

Choose a reason for hiding this comment

Uh oh!

namyoungkim left a comment

Choose a reason for hiding this comment

Uh oh!

Normalist-K left a comment

Choose a reason for hiding this comment

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

namyoungkim commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

namyoungkim left a comment

Choose a reason for hiding this comment

Uh oh!

pupba commented Jan 18, 2025

Uh oh!

sohyunwriter commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pupba commented Jan 14, 2025 •

edited

Loading

Normalist-K left a comment •

edited

Loading

namyoungkim commented Jan 18, 2025 •

edited

Loading

sohyunwriter commented Jan 18, 2025 •

edited

Loading