Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[E-3] 16-Evaluations / 09-CompareEvaluation #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 18, 2025
Merged

[E-3] 16-Evaluations / 09-CompareEvaluation #374

merged 3 commits into from
Jan 18, 2025

Conversation

ppakyeah
Copy link
Contributor

@ppakyeah ppakyeah commented Jan 15, 2025 •
edited
Loading

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@ppakyeah ppakyeah requested review from sunworl and choincnp January 15, 2025 06:33
@ppakyeah ppakyeah self-assigned this Jan 15, 2025
choincnp
choincnp requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@choincnp choincnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:
    안녕하세요 @ppakyeah 님! 너무 좋은 튜토리얼 작성하시느라 고생 많으셨습니다!
    다만 조금 템플릿에 맞지 않아 고쳐야 할 부분 있어 Request changes 작성하였습니다.
  1. Table of Contents에는 ##까지만 link되어야 합니다.
    Define functions for RAG Performance Testing 및 Comparing the result 부분은 ### 으로 이루어져 있어 Table of Contents에 들어가지 않아야 하거나, ##로 이루어져 있어야 합니다.

나머지는 제 기준으로는 완벽합니다 :) 설명도 좋고 Code execution, image도 잘 첨부되어 있는 것으로 보여집니다. 다시한번 고생 많으셨어요!!

@ppakyeah ppakyeah requested a review from choincnp January 16, 2025 04:31
@ppakyeah
Copy link
Contributor Author

@choincnp 감사합니다!! Table of Contents 수정했습니다 리뷰 다시 한번 부탁드리겠습니다 :)

choincnp
choincnp previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@choincnp choincnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!!! :)

@sunworl
Copy link
Contributor

sunworl commented Jan 17, 2025

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

고생하셨습니다.
오류 없이 잘 수행되는 것 확인했습니다.

다만, "Environment Setup"에서 아래의 부분이 빠진거 같은데요. 확인부탁드립니다.
image

@ppakyeah
Copy link
Contributor Author

🖥️ OS: Win ✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}

고생하셨습니다. 오류 없이 잘 수행되는 것 확인했습니다.

다만, "Environment Setup"에서 아래의 부분이 빠진거 같은데요. 확인부탁드립니다. image

@sunworl 리뷰 감사합니다! 최근에 업데이트 된 템플릿 사용하여 load_dotenv()는 아래 부분에 적용되어 있습니다!
스크린샷 2025-01-17 오후 4 05 08

@ppakyeah
Copy link
Contributor Author

@choincnp myrag 쪽 package 추가가 필요해서 리뷰 한번만 다시 부탁드리겠습니다 ㅠㅠ

@ppakyeah ppakyeah requested a review from choincnp January 17, 2025 07:46
choincnp
choincnp approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@choincnp choincnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@teddylee777 teddylee777 merged commit ab5c221 into LangChain-OpenTutorial:main Jan 18, 2025
1 of 2 checks passed
@sohyunwriter sohyunwriter added the docs tutorial label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunworl sunworl sunworl approved these changes

@choincnp choincnp choincnp approved these changes

Assignees

@ppakyeah ppakyeah

Labels
docs tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ppakyeah @sunworl @choincnp @teddylee777 @sohyunwriter