[E-4] 15-Agent / 03-Agent #377
Conversation
🖥️ OS: Win/Mac/Linux ✅ Checklist - [x] **Template**: The tutorial follows the required template. - [x] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No) - [x] **Image**: Image filenames follow the guidelines. - [x] **Imports*: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. - [x] **Code Execution**: Code runs without errors. - Comments:
15-Agent/03-Agent.ipynb
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
Comments:
작성하시느라 고생 많으셨습니다! 약간의 피드백 드릴게요
-
- RunnableWithMessageHistory
부분에서 링크를 위키독스로 넣으셨는데요. 한국어 튜토리얼 홈페이지다 보니,
랭체인 홈페이지에 있는 링크를 넣으시면 어떨까 합니다. 주소남겨드릴게요.
https://python.langchain.com/api_reference/core/runnables/langchain_core.runnables.history.RunnableWithMessageHistory.html
- RunnableWithMessageHistory
-
위에서 언급한 RunnableWithMessageHistory를 첫 table of contents에 나오는 References에 추가하는게 좋을것 같습니다.
-
peer review같은경우에는 디자인팀에서 일괄적으로 한다고, 예전에 피드백 받은적이 있습니다. 내용은 지우시는게 좋아보입니다.
긴내용 작업 하시느라 고생많으셨습니다.
|
🖥️ OS: Mac
Jae-hoya 이 언급하신 한글 위키독스 링크 외에 수정 요청이 없구요. |
|
@BaBetterB 님, @Jae-hoya 님, 꼼꼼한 리뷰 대단히 감사 합니다. |
|
🖥️ OS: Mac [O] Template: Tutorials follows the required template. |
8c054fd
into
LangChain-OpenTutorial:main
리뷰 부탁 드립니다.
그림 디자인 반영이 되었으며, Prompt 시나리오를 변경하여 적용 하였습니다.
감사 합니다.
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N