Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ThePurpleCollar
Copy link
Contributor

@ThePurpleCollar ThePurpleCollar commented Jan 15, 2025

의견주신것 처럼 환경 설정이 앞으로 나오는 것이 좋아 보입니다.
해당 내용 반영하였습니다.

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@ThePurpleCollar ThePurpleCollar added the proofreading 번역/검수팀 제안사항 반영 label Jan 15, 2025
@ThePurpleCollar ThePurpleCollar self-assigned this Jan 15, 2025
kkam-dragon
kkam-dragon previously approved these changes Jan 15, 2025
Copy link
Contributor

@kkam-dragon kkam-dragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의견 내용 수정해주시느라 정말 고생 많으셨습니다~!

@BokyungisaGod
Copy link
Contributor

안녕하세요 @ThePurpleCollar 님~ 다른 수정사항들 잘 고쳐진거 확인했습니다!
한가지 정도만 더 고쳐주시면 될 것 같아요. 아래 내용 참고 바랍니다.
스크린샷 2025-01-16 오전 4 31 42
base retriever에 backtick처리를 해야 합니다. -> base_retriever

확인해 보시고 이상 있으면 코멘트 남겨주세요~

@ThePurpleCollar
Copy link
Contributor Author

ThePurpleCollar commented Jan 16, 2025

안녕하세요 @BokyungisaGod @kkam-dragon 님~ 리뷰 감사드립니다.

말씀하신 base retriever 부분을 base_retriever로 수정하였습니다.
수정 내용은 커밋에 반영하였으니 확인 부탁드립니다. 혹시 추가적으로 보완해야 할 부분이 있다면 말씀해 주세요.

감사합니다.

@kkam-dragon kkam-dragon self-requested a review January 16, 2025 12:30
Copy link
Contributor

@kkam-dragon kkam-dragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BokyungisaGod 님이 요청하신
base_retriever backtick 처리 확인하였습니다!

드디어 끝인가요~ㅎ

@teddylee777 teddylee777 merged commit c12d596 into LangChain-OpenTutorial:main Jan 17, 2025
1 of 2 checks passed
@ThePurpleCollar ThePurpleCollar deleted the crosscoder3 branch January 19, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants