[E-4] 15-Agent / 01-Tools #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Title] 01-Tools [Version] initial [Language] ENG [Packgage] "langsmith", "langchain", "langchain_core", "langchain_openai", "langchain_experimental", "feedparser" feedparser는 인프라팀에 요청하였습니다. 반영이 안됐을경우, 설치가 필요할 수 있습니다.
JunseongKim1104
requested changes
Jan 15, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments:
작성하시느라 정말 수고 많으셨습니다. 몇가지 피드백 드립니다.
- Tavily API를 사용하는 부분에서 원리 한국어 튜토리얼에는 "추가된 TavilySearch 도구" 라는 내용으로 커스텀 구현한 내용이 있는데요 혹시 그 부분은 의도적으로 삭제하신걸까요?
- Dalle 부분
- 한국어 튜토리얼과 같이 Dalle 에서 생성한 이미지를 결과창에 보여줄 수 있도록 해야 할 것 같습니다!(마크다운 문법 활용)
- 한국어 튜토리얼에서 아무래도 잘못된 부분이 있는 것 같은데요. 이 부분은 제가 틀렸을 수도 있습니다. 튜토리얼에서 언어 모델을 활용해서 이미지 생성을 위한 프롬프트를 언어모델을 활용해서 생성을 하고 해당 프롬프트를 사용해서 dalle로 이미지를 생성해야 하는데 언어 모델의 프롬프트와 이미지 생성에서의 프롬프트가 동일합니다. 이 부분은 수정이 필요 할 것 같아요 @teddylee777 님 이 부분 제가 파악한게 맞을까요?
ex)
image_url = dalle.run(chain.invoke({"image_desc": image_prompt}))
[Title] 01-Tools [Version] econd [Language] ENG [Packgage] "langsmith", "langchain", "langchain_core", "langchain_openai", "langchain_experimental", "tavily-python", "feedparser" 이미지를 추가하였습니다. tavily로 custom쪽을 추가했습니다.
github을 보고 작업하였는데, 거기엔 없어서 작업하지 않았습니다. tavily를 custom tool 만들기를 추가했습니다.
|
ranian963
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
🖥️ OS: Mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments:
코드와 링크가 잘 동작 함을 확인하였습니다.
그외 특별히 문제가 있는 것은 없는 것 같습니다.
이번주도 수고 많으 셨습니다.
|
@Jae-hoya 님 안녕하세요 내용:
|
JunseongKim1104
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments:
확인 완료하였습니다. 수고하셨습니다!
544b4e0
into
LangChain-OpenTutorial:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Title] 01-Tools
[Version] initial
[Language] ENG
[Packgage] "langsmith", "langchain", "langchain_core", "langchain_openai", "langchain_experimental", "feedparser"
feedparser 패키지는 요청 해놓은 상태입니다.
반영이 안됐을경우, 설치가 필요할 수 있습니다.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.