Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[E-4] 15-Agent / 02-Bind-Tools #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 18, 2025
Merged

[E-4] 15-Agent / 02-Bind-Tools #391

merged 4 commits into from
Jan 18, 2025

Conversation

geminii01
Copy link
Member

@geminii01 geminii01 commented Jan 15, 2025 •
edited
Loading

[Note] Change Naver News crawling to BBC News crawling

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux
✅ Checklist
 - [ ] **Template**: Tutorials follows the required template.
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@geminii01
[E-4] 15-Agent / 02-Bind-Tools
4588c1a 
- OS: Win
- Comments: Change Naver News crawling to BBC News crawling
@geminii01 geminii01 self-assigned this Jan 15, 2025
@jhboyo
Copy link
Contributor

jhboyo commented Jan 16, 2025 •
edited
Loading

🖥️ OS:Mac
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {
    코드 정상 작동하고 특이사항 없어 보입니다.
    고생하셨습니다!
    }

jhboyo
jhboyo previously approved these changes Jan 16, 2025
View reviewed changes
Hye-yoonJeong
Hye-yoonJeong previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Hye-yoonJeong Hye-yoonJeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:
  1. the word 'LangChain OpenTutorial' -> words로 바꾸면 어떨까요?
  2. Let's try adding more than two values. This is not the end of the execution. It repeats the process of checking its own result and executing it again. -> Let's try adding more than two numbers. In this process, you can observe that the agent verifies its own results and repeats the process if necessary. 로 수정하면 조금 더 잘 읽힐 것 같습니다.

@geminii01 geminii01 dismissed stale reviews from Hye-yoonJeong and jhboyo via aa0670f January 16, 2025 10:15
@geminii01
Copy link
Member Author

geminii01 commented Jan 16, 2025 •
edited
Loading

the word 'LangChain OpenTutorial'? 를 the words 'LangChain OpenTutorial'? 로 변경해서 반영하였습니다.
다시 실행해보니 LangChain OpenTutorial 전체를 인식하지 않고 있는데요.
혹시 단어에서 띄어쓰기를 제거해서 LangChainOpenTutorial 로 변경하는 것은 어떤지 여쭤보고 싶습니다.

@Hye-yoonJeong
Copy link
Contributor

the word 'LangChain OpenTutorial'? 를 the words 'LangChain OpenTutorial'? 로 변경해서 반영하였습니다. 다시 실행해보니 LangChain OpenTutorial 전체를 인식하지 않고 있는데요. 혹시 단어에서 띄어쓰기를 제거해서 LangChainOpenTutorial 로 변경하는 것은 어떤지 여쭤보고 싶습니다.

사소한 의견까지 반영하시느라 고생이 많으십니다!

시험삼아

  1. get_word_length 툴을 정의할 때 Return the length of a word -> Return the length of the given text 로 수정
  2. What is the length of the words 'LangChain OpenTutorial'? -> What is the length of the given text 'LangChain OpenTutorial'? 로 수정
    해보니 [Execution Result] 22 가 나오긴 하는데

의도에 맞게 재민님이 제안하신 것과 제안드린 내용 중에 선택하시면 될 것 같습니다!

@geminii01
Copy link
Member Author

the word 'LangChain OpenTutorial'? 를 the words 'LangChain OpenTutorial'? 로 변경해서 반영하였습니다. 다시 실행해보니 LangChain OpenTutorial 전체를 인식하지 않고 있는데요. 혹시 단어에서 띄어쓰기를 제거해서 LangChainOpenTutorial 로 변경하는 것은 어떤지 여쭤보고 싶습니다.

사소한 의견까지 반영하시느라 고생이 많으십니다!

시험삼아

  1. get_word_length 툴을 정의할 때 Return the length of a word -> Return the length of the given text 로 수정
  2. What is the length of the words 'LangChain OpenTutorial'? -> What is the length of the given text 'LangChain OpenTutorial'? 로 수정
    해보니 [Execution Result] 22 가 나오긴 하는데

의도에 맞게 재민님이 제안하신 것과 제안드린 내용 중에 선택하시면 될 것 같습니다!

given text 로 변경했는데, 띄어쓰기 제거 안 해도 잘 나옵니다!! 감사합니다😊👍
추가 반영한 후에 디코로 연락드리겠습니다!

@geminii01
fix: Use the 'given text'
b152f6c 
- Update `get_word_length` function message
- Update input message
Hye-yoonJeong
Hye-yoonJeong approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Hye-yoonJeong Hye-yoonJeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다! :)

jhboyo
jhboyo approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@jhboyo jhboyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS:Mac
✅ Checklist

[O] Template: Tutorials follows the required template.
[O] Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
[O] Image: Image filenames follow guidelines.
[O] Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
[O] Code Execution: Code runs without errors.
Comments: {
고생하셨습니다!
}

@teddylee777 teddylee777 merged commit d6998ea into LangChain-OpenTutorial:main Jan 18, 2025
1 of 2 checks passed
@sohyunwriter sohyunwriter added the docs tutorial label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhboyo jhboyo jhboyo approved these changes

@Hye-yoonJeong Hye-yoonJeong Hye-yoonJeong approved these changes

Assignees

@geminii01 geminii01

Labels
docs tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geminii01 @jhboyo @Hye-yoonJeong @teddylee777 @sohyunwriter