Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

seofield
Copy link
Contributor

@seofield seofield commented Jan 15, 2025

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@seofield seofield force-pushed the main-fix branch 2 times, most recently from d7d5ba7 to c747637 Compare January 15, 2025 13:24
Copy link
Contributor

@PangPangGod PangPangGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그리고 전체적으로 backtick같은거 체크 한번만 더 해주시면 감사하겠습니다!

아마 검수팀에서 한번 더 볼 것 같긴 한데 전체적으로 빠져 있네요.

"cell_type": "markdown",
"metadata": {},
"source": [
"# Erros\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분과 file name에 오타가 있네요!

# Erros -> # Errors
16-LangGraph-Erros.ipynb -> 16-LangGraph-Errors.ipynb

"\n",
"### References\n",
"\n",
"- [LangGraph API Reference](https://langchain-ai.github.io/langgraph/reference/errors/)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분도 LangGraph API Reference보다는 설명을 조금 더 해주면 좋을것 같아요

LangGraph API Reference -> LangGraph API Reference: Errors

Copy link
Contributor

@acho98 acho98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 이 튜토리얼에는 하기 키가 필요없어 보입니다.
    "OPENAI_API_KEY": "",
    "LANGCHAIN_API_KEY": "",
    "LANGCHAIN_TRACING_V2": "true",
    "LANGCHAIN_ENDPOINT": "https://api.smith.langchain.com",
    "LANGCHAIN_PROJECT": "",

  2. 마지막 빈셀들 삭제해주셔야할거 같아요

Copy link
Contributor

@PangPangGod PangPangGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Windows
✅ Checklist

  • [ ✅ ] Template: Tutorials follows the required template.
  • [ ✅ ] Table of Contents(TOC) Links: All Table of Contents links work. ((Yes/No)
  • [ ✅ ] Image: Image filenames follow guidelines.
  • [ ✅ ] *Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • [ ✅ ] Code Execution: Code runs without errors.
  • Comments: 피드백 하신 부분 확인했습니다. 고생하셨습니다.

@acho98 acho98 requested review from PangPangGod and acho98 January 17, 2025 14:16
Copy link
Contributor

@acho98 acho98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@teddylee777 teddylee777 changed the title [N-3] 17-LangGraph / 01-Core-Features / 16-LangGraph-Erros [N-3] 17-LangGraph / 01-Core-Features / 16-LangGraph-Errors Jan 18, 2025
@teddylee777 teddylee777 merged commit b5e2254 into LangChain-OpenTutorial:main Jan 24, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants