Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

harheem
Copy link
Contributor

@harheem harheem commented Jan 15, 2025

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@harheem harheem self-assigned this Jan 15, 2025
Copy link
Contributor

@JunseongKim1104 JunseongKim1104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.

안녕하세요 정말 고생 많으셨습니다.

  1. PDF 파일의 다운로드 링크가 빠진 것 같습니다. 디스코드에 있는 가이드에 따르면 아래와 같은 형식으로 파일 다운로드 정보를 제공하도록 안내합니다.
    `Document Used for Practice

A European Approach to Artificial Intelligence - A Policy Perspective

Author: EIT Digital and 5 EIT KICs (EIT Manufacturing, EIT Urban Mobility, EIT Health, EIT Climate-KIC, EIT Digital)
Link: https://eit.europa.eu/sites/default/files/eit-digital-artificial-intelligence-report.pdf
File Name: A European Approach to Artificial Intelligence - A Policy Perspective.pdf

Please copy the downloaded file to the data folder for practice.`

  1. RecursiveCharacterTextSplitter() 패키지가 구버전으로 불러오고 있습니다. 이 부분은 수정이 필요해 보입니다

@suhyun0115
Copy link
Contributor

suhyun0115 commented Jan 16, 2025

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    안녕하세요! pdf를 어디서 받아야 할 지 모르겠습니다.. 링크 주시면 그 후에 마저 리뷰하겠습니다.

@harheem
Copy link
Contributor Author

harheem commented Jan 17, 2025

@JunseongKim1104 @suhyun0115 반영이 늦어서 정말 죄송합니다 😂 다시 한번 리뷰 부탁드립니다. 감사합니다!

@JunseongKim1104 JunseongKim1104 self-requested a review January 17, 2025 12:13
Copy link
Contributor

@JunseongKim1104 JunseongKim1104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win/Mac/Linux
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:

정말 수고 많으셨습니다. 한가지만 말씀 드리면 TOC는 level2 헤더만 연결해야 한다고 하더라구요. 저도 이번에 알았습니다. 이 부분만 고치시면 될 것 같습니다!

수정 후

@harheem
Copy link
Contributor Author

harheem commented Jan 17, 2025

@JunseongKim1104 헉! 정말 감사드립니다. 말씀하신 코멘트 반영하였습니다 😂

@suhyun0115
Copy link
Contributor

suhyun0115 commented Jan 18, 2025

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    고생하셨습니다!!

Copy link
Contributor

@JunseongKim1104 JunseongKim1104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments:

수고하셨습니다~!

@teddylee777 teddylee777 merged commit bce3c21 into LangChain-OpenTutorial:main Jan 18, 2025
1 of 2 checks passed
@sohyunwriter sohyunwriter added the docs tutorial label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants