[E-4] 15-Agent / 11-React-Agent.ipynb #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{PR Message - Write freely, remove this bracket if unnecessary}
### Author Checklist
- [x] **PR Title Format**: I have confirmed that the PR title follows the correct format. _(e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)_
- [x] **Committed Files**: I have ensured that no unnecessary files _(e.g., .bin, .gitignore, poetry.lock, pyproject.toml)_ are included. These files are not allowed.
- [ ] **(Optional) Related Issue**: If this PR is linked to an issue, I have referenced the issue number in the PR message. _(e.g., Fixes LangChain-OpenTutorial#123)_
- ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
### Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N
Jae-hoya
previously approved these changes
Jan 15, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work.
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments:
고생많으셨습니다. 수고하셨습니다.
안에 pdf파일은 저작권때문에 따로 data 넣지 않으시고, 링크로 달아놓으신거 맞나요?
|
@Jae-hoya 네 디스코드의 참고 data 가이드에 링크로 하는 것도 나와 있어서 그렇게 하였고 |
geminii01
reviewed
Jan 16, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- [N/A] Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments
- 코드 실행 모두 잘 됩니다. 추가 API Key 발급 설명도 잘 되어있습니다. 고생 많으셨습니다!!
- 그래프 구조의 이미지가 tmp 폴더에 저장되도록 하면 어떨까요?
=> 마지막 2개의 셀에서 이러한 표시가 뜨는데, 일반적인 작은 따옴표로 변경하는 것은 어떨까요?
|
@geminii01 넵 말씀주신 내용 확인하였습니다. |
"Please find information related to the major AI-related from CES 2025" 찾는 예시 문구를 수정하였습니다. 말씀주신 마지막 2개 셀의 특수문자를 수정하였습니다. 이미지를 tmp에 생성하는 것 같은 경우 해당 코드 위치에서는 tmp 폴더가 생성되지 않아서 의도적으로 폴더 생성 코드가 추가되어야 해서 지금 그대로 유지 했으면 하는데 의견 다시 부탁드립니다.
geminii01
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
🖥️ OS: Win
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- [N/A] Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: 고생 많으셨습니다!!
Jae-hoya
approved these changes
Jan 18, 2025
36d43e3
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N