[E-3] 16-Evaluations / 13-LangSmith-Repeat-Evaluation #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
π₯οΈ OS: Win/Mac/Linux
|
|
@ppakyeah 리뷰 κ°μ¬ν©λλ€! νν λ¦¬μΌ λ³΄μνκ³ μλ €λλ¦¬κ² μ΅λλ€. |
sungchul2
requested changes
Jan 16, 2025
There was a problem hiding this comment.
π₯οΈ OS: Win/Mac/Linux
β
Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- λ§μ§λ§ μ
μμ
ChatOllamaλ‘ νκ° μ€ μλμ κ°μ μλ¬κ° λ°μνκ³ μμ΅λλ€. νμΈν΄λ³Έ κ²°κ³Ό,runμ΄{"output": None}μ΄μ΄μ λ°μνκ³ μμ΅λλ€. νΉμ μ λ§ κ·Έλ°κ±΄μ§, λλΈμ²΄ν¬ λΆνλ립λλ€.
- λ§μ§λ§ μ
μμ
...
ollama._types.ResponseError: model 'llama3.2' not found, try pulling it first
Error running evaluator <DynamicRunEvaluator evaluate> on run cf34c270-2371-4e9c-bec6-9a3050491781: KeyError('answer')
Traceback (most recent call last):
File "/home/sungchul/.pyenv/versions/langchain_tutorial_1/lib/python3.11/site-packages/langsmith/evaluation/_runner.py", line 1573, in _run_evaluators
evaluator_response = evaluator.evaluate_run(
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/sungchul/.pyenv/versions/langchain_tutorial_1/lib/python3.11/site-packages/langsmith/evaluation/evaluator.py", line 331, in evaluate_run
result = self.func(
^^^^^^^^^^
File "/home/sungchul/.pyenv/versions/langchain_tutorial_1/lib/python3.11/site-packages/langsmith/run_helpers.py", line 617, in wrapper
raise e
File "/home/sungchul/.pyenv/versions/langchain_tutorial_1/lib/python3.11/site-packages/langsmith/run_helpers.py", line 614, in wrapper
function_result = run_container["context"].run(func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/sungchul/.pyenv/versions/langchain_tutorial_1/lib/python3.11/site-packages/langsmith/evaluation/integrations/_langchain.py", line 258, in evaluate
else self._prepare_data(run, example)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/ipykernel_1064808/2296627391.py", line 8, in <lambda>
"prediction": run.outputs["answer"],
~~~~~~~~~~~^^^^^^^^^^
KeyError: 'answer'
- Comments: {Write freely, νκ΅μ΄ κΈ°μ κ°λ₯}
|
@rlatjcj 리뷰 κ°μ¬ν©λλ€. μλ¬ λλ λΆλΆ μμ ν΄μ μ¬λ¦¬κ² μ΅λλ€. |
|
@ppakyeah μ΄λ―Έμ§ νμΌλͺ
μμ λ° νν λ¦¬μΌ λ΄μ© 보μ νμμ΅λλ€! |
sungchul2
requested changes
Jan 17, 2025
There was a problem hiding this comment.
π₯οΈ OS: Linux
β
Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, νκ΅μ΄ κΈ°μ κ°λ₯}
ppakyeah
reviewed
Jan 17, 2025
|
@ppakyeah λ§μν΄μ£Όμ μΉμ
μ 컨ν
μΈ μΆκ°νμμ΅λλ€. |
sungchul2
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
π₯οΈ OS: Linux
β
Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, νκ΅μ΄ κΈ°μ κ°λ₯}
- κ³ μλ§μΌμ ¨μ΅λλ€!
ppakyeah
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
π₯οΈ OS:Mac
β
Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, νκ΅μ΄ κΈ°μ κ°λ₯}
κ³ μνμ ¨μ΅λλ€ !!
c2dbb6e
into
LangChain-OpenTutorial:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynbΒ #123)
β Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N