[E-3] 16-Evaluations / 08-LangSmith-Heuristic-Evaluation #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppakyeah
requested changes
Jan 16, 2025
There was a problem hiding this comment.
🖥️ OS: Win/Mac/Linux
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
구체적인 예시들이 추가로 포함되어서 좋았습니다! 👍
내용은 잘 작성된 것으로 보이지만, 제 기기에서는 코드 실행 시에 문제가 있어 몇가지 수정 요청드립니다!
|
🖥️ OS: Win
수고하셨습니다. |
…ial/LangChain-OpenTutorial into pr/404" This reverts commit 323f90b, reversing changes made to 78c68ec.
꼼꼼한 리뷰 감사합니다. 검토해주신 내용들 모두 반영하여 수정하였습니다.
파일명 오류 파일 삭제
…rial/LangChain-OpenTutorial into pr/404" This reverts commit e4d217c.
|
에러 발생 없이 모두 잘 출력되네요! 수고하셨습니다:) |
…stic-evaluation-01.png
…stic-evaluation-02.png
| "Check the results.\n", | ||
| "\n", | ||
| "\n", | ||
| " " |
There was a problem hiding this comment.
참조하는 코드도 변경된 파일명과 동일하게 수정 부탁드립니다.
| "\n", | ||
| " > Note: What is N-gram?\n", | ||
| "\n", | ||
| " \n", |
There was a problem hiding this comment.
이미지 파일 참조하는 코드도 수정 부탁드립니다.
ppakyeah
reviewed
Jan 17, 2025
There was a problem hiding this comment.
🖥️ OS: Mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
정상 동작합니다. 고생 많으셨습니다! 아래 코멘트 하나만 더 확인 부탁드릴게요!
forwardyoung
previously approved these changes
Jan 17, 2025
# Install required packages "langsmith.schemas" 삭제
forwardyoung
approved these changes
Jan 17, 2025
e46e436
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N