[E-1] 10-Retriever / 09-TimeWeightVectorStoreRetriever #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee-juni
requested changes
Jan 16, 2025
|
@ee-juni 빠른 교정 감사합니다! 😄 👍 추가로, langsmith가 tracking하는 file의 제목도 timeweight로 되어있어 timeweighted로 수정하였고, 제목에 백틱 붙이지 않는걸로 협의한것으로 판단되어 해당 내용 제거하였습니다! :) |
ee-juni
approved these changes
Jan 16, 2025
BokyungisaGod
approved these changes
Jan 16, 2025
e73fd30
into
LangChain-OpenTutorial:main
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 @ee-juni 님, 먼저 정말 좋은 검수 감사합니다.
먼저 제목같은 핵심적인 부분에서 실수가 있었던 점 죄송합니다! 조금 더 꼼꼼히 봤어야 했는데...!
외에도 영문법에 약한 제가 놓쳤던 실수들 잘 봐주셔서 감사합니다.
내용은 전부 수정하였습니다. Mocked Time같은 경우는 모킹을 생각하고 그대로 썼다가 고쳐주셔서 의아했는데,
생각해보니 준의님 말씀처럼 바꾸는 게 맞다고 생각했습니다 :)
좋은 하루 되세요! 나중에 또 파일에서 뵙겠습니다~ ㅎㅎㅎ
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Proofread: < 10-Retriever / 09-TimeWeightedVectorStoreRetriever > #407 )
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.