Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[E-4] 15-Agent / Agent-More-LLMs #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 18, 2025
Merged

[E-4] 15-Agent / Agent-More-LLMs #410

merged 5 commits into from
Jan 18, 2025

Conversation

jhboyo
Copy link
Contributor

@jhboyo jhboyo commented Jan 16, 2025 •
edited
Loading

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@jhboyo jhboyo requested review from harheem and suhyun0115 January 16, 2025 06:01
@jhboyo
Copy link
Contributor Author

jhboyo commented Jan 16, 2025

@suhyun0115 @harheem
기존 PR을 Close하고 새로 만들어 다시 리뷰 요청 드립니다.
공지사항에 있는 ANTHROPIC_API_KEY는 만료되어 재발급 요청하겠습니다.

@suhyun0115
Copy link
Contributor

suhyun0115 commented Jan 16, 2025 •
edited
Loading

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    안녕하세요. gemini = ChatGoogleGenerativeAI(model="gemini-1.5-pro", temperature=0)
    코드 실행 중 에러가 발생하는데,
    DefaultCredentialsError: Your default credentials were not found. To set up Application Default Credentials, see https://cloud.google.com/docs/authentication/external/set-up-adc for more information. 에러가 뜨는데 키가 유출돼서 만료가 된건지 사용자 인증 설정에서 제가 따로 뭘 추가로 해줘야 하는지 모르겠습니다. 확인 부탁드립니다.
    그리고 references에 tool calling agent, openai tools가 outdated 됐습니다.

@jhboyo
modify reference link
2e05554 
modify link - Tool Calling Agent
remove link - OpenAI Tools
@jhboyo
Copy link
Contributor Author

jhboyo commented Jan 17, 2025

@suhyun0115
리뷰 반영하였습니다.

  1. 참고 링크 수정
  1. Tool Calling Agent - 링크 수정
  2. OpenAI Tools - 링크 삭제 (아래 LangChain ChatOpenAI로 갈음)

Gemini는 set_env에 키를 넣고 다시한번 리뷰 요청 드립니다!

@harheem
Copy link
Contributor

harheem commented Jan 17, 2025

@jhboyo 안녕하세요! 친절하고 좋은 튜토리얼 감사드립니다 :)
코드 돌아가는데 전반적으로 문제 없으나, 아래사항 수정하시면 리뷰 템플릿과 함께 Approve 남기도록 하겠습니다!

  1. from langchain.agents import create_tool_calling_agent 를 2번 정의하고 있습니다. 하나만 정의하도록 수정부탁드립니다.
  2. 마지막 셀을 위해 Ollama 가이드 부분에서 ollama pull llama3.1와 함께 ollama pull qwen2.5 명령어를 추가하시면 좋을 것 같습니다 ☺️

@jhboyo
[update][E-4] 15-Agent / Agent-More-LLMs
b852d57 
1. remove duplicated imports
2. add command for qwen2.5
@jhboyo
Copy link
Contributor Author

jhboyo commented Jan 17, 2025

@harheem
리뷰 감사드립니다!
리뷰주신 부분 수정하였습니다. 확인 부탁드리고 추가 수정할 부분이 있으면 안내주시면 감사하겠습니다.

@jhboyo
print outputs
bf6ef1f 
print ipynb outputs
harheem
harheem approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@harheem harheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Mac
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: 👍🏻

suhyun0115
suhyun0115 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@suhyun0115 suhyun0115 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖥️ OS: Win
✅ Checklist

  • Template: Tutorials follows the required template.
  • Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
  • Image: Image filenames follow guidelines.
  • Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
  • Code Execution: Code runs without errors.
  • Comments: {Write freely, 한국어 기술 가능}
    고생하셨습니다!!

@teddylee777 teddylee777 merged commit 3b28397 into LangChain-OpenTutorial:main Jan 18, 2025
1 of 2 checks passed
@sohyunwriter sohyunwriter added the docs tutorial label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harheem harheem harheem approved these changes

@suhyun0115 suhyun0115 suhyun0115 approved these changes

Assignees
No one assigned
Labels
docs tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jhboyo @suhyun0115 @harheem @teddylee777 @sohyunwriter