Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

back2zion
Copy link
Contributor

git commit -m "[Team] 신규1팀 UseCase
[Title] 02-SpeechtoSQL.ipynb
[Version] 1.1
[Language] ENG
{Package] sounddevice, wavio, faster-whisper

{PR Message - Write freely, remove this bracket if unnecessary}

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

git commit -m "[Team] 신규1팀 UseCase
[Title] 02-SpeechtoSQL.ipynb
[Version] 1.1
[Language] ENG
{Package] sounddevice, wavio, faster-whisper
Copy link
Contributor

@ash-hun ash-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS: Windows 11
  • Template Rule 준수 여부: Template형태를 잘 지키셨습니다.
  • Table of Contents 링크 확인: 이상없습니다.
  • 이미지 파일명 검토: 해당사항 없습니다.
  • 최신 import 방식 사용 여부: 정상동작합니다. 이상없습니다.
  • 코드 동작 확인: 이상없습니다.
  • 제출 파일 확인: 필요한 파일들만 포함됨

기타 의견:

한 차례 PR 수정한다고 너무 고생하셨습니다! 😊 내용도 너무 훌륭합니다 ㅎㅎ

Copy link
Contributor

@johnny9210 johnny9210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Review Checklist]

  • Review OS: Mac
  • Template Rule 준수 여부: Template형태를 잘 지키셨습니다.
  • Table of Contents 링크 확인: 이상없음
  • 이미지 파일명 검토: 해당사항 없음
  • 최신 import 방식 사용 여부: 정상동작
  • 코드 동작 확인: 이상없음
  • 제출 파일 확인: 필요한 파일들만 포함됨

고생하셨습니다!!!

@johnny9210 johnny9210 self-requested a review January 17, 2025 15:17
@back2zion back2zion self-assigned this Jan 18, 2025
@teddylee777 teddylee777 merged commit be76e12 into LangChain-OpenTutorial:main Jan 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants