[E-4] 13-LangChain-Expression-Language / 04-Routing 이슈 사항 반영 #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Team] 16-evaluations [Title] add the files [Version] initial [Language] ENG [files] myrag.py, Newwhitepaper_Agents2.pdf
code and contents update add image file
chaeyoonyunakim
previously approved these changes
Jan 18, 2025
|
@jinucho 님 안녕하세요. 수정사항이 몇가지 있어 코멘트를 남기게 되었습니다 
* 앞으로는 소제목에도 함수명/모듈명/변수명이 포함되어 있을 시 backtick처리를 하기로 했습니다. 참고해주세요!
Runnable은 함수명/모듈명/변수명에 해당 안되지 않나요..?? 확인 후 의견 주시면 감사하겠습니다.
*소제목에도 backtick처리 해주세요!
*소제목에도 backtick처리 해주세요! 제가 틀렸을 수도 있어용. 확인해보시고 수정 후 말씀주세요~! |
말씀해주신 사항 반영 했습니다. Runnable은 언급해주신대로 변수나 함수명이 아닌 개념적 용어이므로 백틱 제거 및 소문자로 변경하였습니다. 재검토 요청 드립니다 감사합니다.! |
chaeyoonyunakim
approved these changes
Jan 20, 2025
143a19a
into
LangChain-OpenTutorial:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: Issue Proofread: < 13-LCEL / 04-Routing > #428
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N
제안 주신 수정사항에 대해 반영하였습니다.