[E-2] 17-LangGraph/01-Core-Features/09-DeleteMessages #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhboyo
requested changes
Jan 19, 2025
There was a problem hiding this comment.
🖥️ OS: Mac
✅ Checklist
- [O ] Template: Tutorials follows the required template.
- [O ] Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- [O ] Image: Image filenames follow guidelines.
- [O ] Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- [O ] Code Execution: Code runs without errors.
- Comments:
- 기존 한글 튜토리얼에 없는 Key Components와 Key Details 추가로 인하여 튜토리얼의 설명과 이해를 더 풍부하게 만드는것 같습니다.
- set_env에 "LANGCHAIN_PROJECT": "", 가 채워져있지 않습니다.
- 코드 마지막 줄에 빈 python cell이 있어 이를 삭제해주시면 좋을 듯 합니다.
모든 코드가 정상작동합니다.
고생 많으셨습니다!
|
@jhboyo 수정했습니다! 한번만 더 리뷰 부탁드립니다!! |
jhboyo
previously approved these changes
Jan 20, 2025
There was a problem hiding this comment.
🖥️ OS: Mac
✅ Checklist
- [ O] Template: Tutorials follows the required template.
- [ O] Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- [ O] Image: Image filenames follow guidelines.
- [ O] Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- [ O] Code Execution: Code runs without errors.
- Comments:
수정반영 사항 확인하였고 코드 모두 정상 작동 재확인하였습니다.
고생 많으셨습니다!
ppakyeah
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
🖥️ OS: Mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: {Write freely, 한국어 기술 가능}
정상 동작 합니다 코드에 대한 자세한 설명이 추가되어 많이 배웠네요 고생하셨습니다!
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ppakyeah
requested changes
Jan 21, 2025
ppakyeah
approved these changes
Jan 22, 2025
jhboyo
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
🖥️ OS: Mac
✅ Checklist
- Template: Tutorials follows the required template.
- Table of Contents(TOC) Links: All Table of Contents links work. (Yes/No)
- Image: Image filenames follow guidelines.
- Imports: All import statements use the latest versions. Ensure "langchain-teddynote" is not used.
- Code Execution: Code runs without errors.
- Comments: 파일 위치 수정 확인하였습니다.
1674bde
into
LangChain-OpenTutorial:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N