Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Proofread: < 05-Memory / 01-ConversationBufferMemory > #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2025
Merged

Proofread: < 05-Memory / 01-ConversationBufferMemory > #460

merged 2 commits into from
Jan 22, 2025

Conversation

sungchul2
Copy link
Contributor

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: Proofread: < 05-Memory / 01-ConversationBufferMemory > #430

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@sungchul2 sungchul2 added the proofreading 번역/검수팀 제안사항 반영 label Jan 19, 2025
@sungchul2 sungchul2 self-assigned this Jan 19, 2025
@sungchul2 sungchul2 changed the title [E-4] 05-MEMORY / 01-ConversationBufferMemory Proofread: < 05-Memory / 01-ConversationBufferMemory > Jan 19, 2025
@chaeyoonyunakim chaeyoonyunakim mentioned this pull request Jan 19, 2025
Closed
8 tasks
@BokyungisaGod
Copy link
Contributor

안녕하세요 @rlatjcj 님! 수정사항이 몇가지 있어 comment를 남기게 되었습니다.
1.
스크린샷 2025-01-20 오후 2 36 01
Table of contents에는 backtick처리를 하지 않습니다! HumanMessage, AIMessage에 backtick처리 되어있는 것을 지워주세요!
2.
스크린샷 2025-01-20 오후 2 36 37
!를 %로 바꿔주세요. %로 통일하기로 했습니다.!

이 부분들만 수정 후 커밋해주시면 approve하는걸로 하겠습니다~

@sungchul2
Copy link
Contributor Author

sungchul2 commented Jan 20, 2025 •
edited
Loading

안녕하세요 @rlatjcj 님! 수정사항이 몇가지 있어 comment를 남기게 되었습니다. 1. 스크린샷 2025-01-20 오후 2 36 01 Table of contents에는 backtick처리를 하지 않습니다! HumanMessage, AIMessage에 backtick처리 되어있는 것을 지워주세요! 2. 스크린샷 2025-01-20 오후 2 36 37 !를 %로 바꿔주세요. %로 통일하기로 했습니다.!

이 부분들만 수정 후 커밋해주시면 approve하는걸로 하겠습니다~

@BokyungisaGod 수정했습니다 422cc62. 확인 감사합니다😄

BokyungisaGod
BokyungisaGod approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@BokyungisaGod BokyungisaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다:)

@teddylee777 teddylee777 merged commit 958857a into LangChain-OpenTutorial:main Jan 22, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeyoonyunakim chaeyoonyunakim chaeyoonyunakim approved these changes

@BokyungisaGod BokyungisaGod BokyungisaGod approved these changes

Assignees

@sungchul2 sungchul2

Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sungchul2 @BokyungisaGod @chaeyoonyunakim @teddylee777