Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

harheem
Copy link
Contributor

@harheem harheem commented Jan 21, 2025

앞으로 꼭 반영할 수 있도록 참고하겠습니다. 꼼꼼한 리뷰 감사드립니다 :)

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: Proofread: < 10-Retriever / 11-Convex-Combination-Ensemble-Retriever > #387

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}     

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@harheem harheem added the proofreading 번역/검수팀 제안사항 반영 label Jan 21, 2025
@harheem harheem self-assigned this Jan 21, 2025
@harheem harheem closed this Jan 21, 2025
@kkam-dragon
Copy link
Contributor

리뷰 하려고 들어왔는데요.. Closed되어 있네요~ 다시 PR 올리시려고 하는건가요~?

@kkam-dragon
Copy link
Contributor

@harheem 님~
이 PR 건이 closed 되어있는데요~ Merge된 이력도 없는 것 같아 보이고요... 어찌 되는건가요~?

@harheem
Copy link
Contributor Author

harheem commented Feb 4, 2025

안녕하세요! @kkam-dragon님, 늦게 확인하여 죄송합니다.
branch가 꼬였는지 자동으로 계속 닫히는 것 같습니다 🥲
수정사항을 커밋하여 반영하는데,, 계속 안되고 있네요. 이 PR을 닫았다가 재시도 해보겠습니다.

@harheem
Copy link
Contributor Author

harheem commented Feb 4, 2025

@kkam-dragon 님! branch가 꼬여있어 저의 역량으로는 해결하기가 쉽지 않네요.
저의 이 PR이 #490 merge가 되고 나면 이 작업을 진행할 수 있을 것 같습니다. 확인이 늦어 거듭 죄송하다는 말씀 드리면서, 다시 언급해주셔서 정말 감사드립니다 :)

@kkam-dragon
Copy link
Contributor

@harheem 님~ 확인 감사드려용!
에구궁... 죄송할 거 없습니다~
수정이 다 되신거라면... 이럴 땐 어떻게 해야 할 지 난감하군요 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants