Thanks to visit codestin.com
Credit goes to github.com

Skip to content

English translation of templates #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 22, 2025
Merged

English translation of templates #478

merged 12 commits into from
Jan 22, 2025

Conversation

touseefahmed96
Copy link
Contributor

@touseefahmed96 touseefahmed96 commented Jan 21, 2025 •
edited
Loading

@chaeyoonyunakim chaeyoonyunakim added question Further clarification/details proofreading ๋ฒˆ์—ญ/๊ฒ€์ˆ˜ํŒ€ ์ œ์•ˆ์‚ฌํ•ญ ๋ฐ˜์˜ check plz labels Jan 21, 2025
@chaeyoonyunakim chaeyoonyunakim self-requested a review January 21, 2025 14:05
chaeyoonyunakim
chaeyoonyunakim previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@chaeyoonyunakim chaeyoonyunakim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. English templates updated; legacy one removed.

@sooyoung-wind @teddylee777 can you take a look at the other files, focusing on the directory hierarchy changes?

@chaeyoonyunakim chaeyoonyunakim mentioned this pull request Jan 21, 2025
Merged
3 tasks
sooyoung-wind
sooyoung-wind requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@sooyoung-wind sooyoung-wind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@touseefahmed96 Please rename the 'english' folder to 'English.

You need to keep the content created by @chaeyoonyunakim is maintained. ๐Ÿ˜„

@touseefahmed96
Copy link
Contributor Author

@touseefahmed96 Please rename the 'english' folder to 'English.

You need to keep the content created by @chaeyoonyunakim is maintained. ๐Ÿ˜„

@sooyoung-wind Done.

@sooyoung-wind sooyoung-wind self-requested a review January 22, 2025 07:31
sooyoung-wind
sooyoung-wind approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@sooyoung-wind sooyoung-wind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ๐Ÿ˜„

ps. how did you find our repo? I was surprised that an outsider found it.

@touseefahmed96
Copy link
Contributor Author

touseefahmed96 commented Jan 22, 2025 •
edited
Loading

Good job ๐Ÿ˜„

ps. how did you find our repo? I was surprised that an outsider found it.

@sooyoung-wind I was learning about agents and new frameworks like smolagents and langgraph then i saw a post on Reddit from @sohyunwriter about this open tutorial about Langchain. It's very interesting. Thanks for this Repo๐Ÿ˜„

teddylee777
teddylee777 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@teddylee777 teddylee777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

@teddylee777 teddylee777 merged commit 58cf4aa into LangChain-OpenTutorial:main Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddylee777 teddylee777 teddylee777 approved these changes

@sooyoung-wind sooyoung-wind sooyoung-wind approved these changes

@chaeyoonyunakim chaeyoonyunakim chaeyoonyunakim left review comments

Assignees
No one assigned
Labels
check plz proofreading ๋ฒˆ์—ญ/๊ฒ€์ˆ˜ํŒ€ ์ œ์•ˆ์‚ฌํ•ญ ๋ฐ˜์˜ question Further clarification/details
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@touseefahmed96 @teddylee777 @sooyoung-wind @chaeyoonyunakim