Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[N-1] 06-DocumentLoader / 01-DocumentLoader #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 24, 2025
Merged

[N-1] 06-DocumentLoader / 01-DocumentLoader #479

merged 5 commits into from
Jan 24, 2025

Conversation

geminii01
Copy link
Member

Author Checklist

  • PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)

  • Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.

  • (Optional) Related Issue: Fixes Proofread: < 06-DocumentLoader / 01-DocumentLoader.ipynb > #417

  • ❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.

Review Template (Intial PR)

🖥️ OS: Win/Mac/Linux   
✅ Checklist      
 - [ ] **Template**: Tutorials follows the required template. 
 - [ ] **Table of Contents(TOC) Links**: All Table of Contents links work. (Yes/No)
 - [ ] **Image**: Image filenames follow guidelines.
 - [ ] **Imports**: All import statements use the latest versions. Ensure "langchain-teddynote" is not used. 
 - [ ] **Code Execution**: Code runs without errors.
 - Comments: {Write freely, 한국어 기술 가능}

If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N

@geminii01 geminii01 added the proofreading 번역/검수팀 제안사항 반영 label Jan 21, 2025
@geminii01 geminii01 self-assigned this Jan 21, 2025
@geminii01 geminii01 changed the title Proofread: < 06-DocumentLoader / 01-DocumentLoader > [N-1] 06-DocumentLoader / 01-DocumentLoader Jan 21, 2025
@chaeyoonyunakim chaeyoonyunakim requested review from BokyungisaGod and removed request for chaeyoonyunakim January 21, 2025 13:15
@Q0211
Copy link

Q0211 commented Jan 21, 2025

안녕하세요 @geminii01 님. 번역검수팀의 문규식입니다.
다름이 아니라 제가 Documents를 class가 아닌 모듈로 잘못 파악을 하는 바람에 잘못된 검수 정보를 드렸던 것 같습니다.
따라서 해당 부분을 수정한 링크를 첨부합니다. 괜찮으시면 다시 해당부분의 backtick을 해제해주시면 감사하겠습니다.
번역 / 검수 참고 링크 1
번역 / 검수 참고 링크 2

BokyungisaGod
BokyungisaGod previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@BokyungisaGod BokyungisaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다:)

@geminii01
Copy link
Member Author

@Q0211 @BokyungisaGod
안녕하세요!
번역/검수 참고하여 수정하였습니다. 재검토 부탁드립니다.
감사합니다!

@BokyungisaGod
Copy link
Contributor

안녕하세요 @geminii01 님, 수정사항이 몇가지 있어 코멘트를 남기게 되었습니다.
1.
스크린샷 2025-01-23 오전 10 10 57
여기서 맨 첫줄의 Dcoument Loader말고 examples Document Loader~에서의 Document Loader과 아래 ~Loader로 끝나는 여러 항목들에 backtick처리를 해야 합니다. (PyPDFLoader, CSVLoader, UnstructuredHTMLLoader, JSONLoader, TextLoader, DirectoryLoader)

이 부분만 재민님께서 검토 후 고쳐서 커밋 해주시면 될 것 같아요. 혹시 이상한 것 같으면 언급+코멘트 주세요!

@geminii01
Copy link
Member Author

geminii01 commented Jan 23, 2025 •
edited
Loading

@Q0211 @BokyungisaGod
안녕하세요!
backtick 처리 반영하였습니다. 재검토 부탁드립니다.
감사합니다!

BokyungisaGod
BokyungisaGod approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@BokyungisaGod BokyungisaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다:)

@geminii01 geminii01 requested a review from teddylee777 January 24, 2025 07:45
@chaeyoonyunakim chaeyoonyunakim self-requested a review January 24, 2025 17:26
@teddylee777 teddylee777 merged commit bc6a6f9 into LangChain-OpenTutorial:main Jan 24, 2025
3 of 4 checks passed
@geminii01 geminii01 deleted the pr-417 branch February 21, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeyoonyunakim chaeyoonyunakim chaeyoonyunakim approved these changes

@BokyungisaGod BokyungisaGod BokyungisaGod approved these changes

@Q0211 Q0211 Awaiting requested review from Q0211

@teddylee777 teddylee777 Awaiting requested review from teddylee777

Assignees

@geminii01 geminii01

Labels
proofreading 번역/검수팀 제안사항 반영
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proofread: < 06-DocumentLoader / 01-DocumentLoader.ipynb >
5 participants
@geminii01 @Q0211 @BokyungisaGod @chaeyoonyunakim @teddylee777